Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Form Validation] Avoid trim of values before validation #27

Merged
merged 2 commits into from
Jun 19, 2018
Merged

[Form Validation] Avoid trim of values before validation #27

merged 2 commits into from
Jun 19, 2018

Conversation

prudho
Copy link
Contributor

@prudho prudho commented Jun 13, 2018

@prudho prudho added lang/javascript Anything involving JavaScript state/awaiting-reviews Pull requests which are waiting for reviews labels Jun 13, 2018
@prudho prudho changed the base branch from master to next June 13, 2018 13:17
@y0hami
Copy link
Member

y0hami commented Jun 13, 2018

This needs some discussion before we move forward.

It was brought up that users may want to trim at the start, end or never and this also needs support for backwards compatibility.

@y0hami y0hami added type/discussion Anything which is up for discussion state/on-hold Issues and pull requests which are on hold for any reason and removed state/awaiting-reviews Pull requests which are waiting for reviews labels Jun 13, 2018
@prudho prudho added the state/awaiting-docs Pull requests which need doc changes/additions label Jun 18, 2018
@y0hami y0hami added Can Merge and removed type/discussion Anything which is up for discussion state/on-hold Issues and pull requests which are on hold for any reason labels Jun 18, 2018
@y0hami y0hami self-requested a review June 18, 2018 12:44
@y0hami y0hami added state/has-docs A issue/PR which requires documentation changes and has the corresponding PR open in the docs repo and removed state/awaiting-docs Pull requests which need doc changes/additions labels Jun 18, 2018
@y0hami y0hami merged commit e6fcadd into fomantic:next Jun 19, 2018
@prudho prudho deleted the fix-6237 branch July 5, 2018 04:59
@lubber-de lubber-de mentioned this pull request May 9, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@y0hami y0hami y0hami approved these changes

Assignees
No one assigned
Labels
lang/javascript Anything involving JavaScript state/has-docs A issue/PR which requires documentation changes and has the corresponding PR open in the docs repo
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@prudho @y0hami