fix(dropdown): possible XSS through select option text #2705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lubber-de
added
type/bug
|
@all-contributors please add @brian-codes for security |
|
I've put up a pull request to add @brian-codes! 🎉 |
lubber-de
removed
the
state/awaiting-reviews
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a possible XSS through an entity encoded select option text when converted into a FUI dropdown.
Even if
preserveHTML: falsewould prevent this, a select tag cannot contain html at all and if it contains entity encoded HTML instead, it should not be reconverted into html.The PR also fixes recreating the dropdown menu twice when no values are selected in a multiple dropdown
Thanks to @brian-codes for reporting
Testcase
Broken
The alert message appears upon selection
https://jsfiddle.net/lubber/f5to49ew/3/
Fixed
All fine
https://jsfiddle.net/lubber/f5to49ew/5/
Closes
#2692 (reply in thread)
#2817