Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TextaArea] Labeled textarea hides text behind icon label #276

Closed
perezdev opened this issue Nov 30, 2018 · 2 comments
Closed

[TextaArea] Labeled textarea hides text behind icon label #276

perezdev opened this issue Nov 30, 2018 · 2 comments
Assignees
Labels
lang/css Anything involving CSS type/feat Any feature requests or improvements
Milestone

Comments

@perezdev
Copy link

perezdev commented Nov 30, 2018

If you setup a left corner labeled input, the text is automatically padded to prevent overlap with the icon:

<div class="ui small left corner labeled input">
    <input type="text" />

    <div class="ui left corner label">
        <i class="asterisk icon"></i>
    </div>
</div>

Result:

image

But if you do the same with a TextArea, the icon label overlaps the text:

<div class="ui left corner labeled input">
    <div class="ui left corner label">
        <i class="asterisk icon"></i>
    </div>
    <textarea rows="2" asp-for="RequestInput.Description"></textarea>
</div>

image

I looked and saw that the input has a 2.5em left padding. Adding that to the textarea fixes the issue.

<div class="ui left corner labeled input">
    <div class="ui left corner label">
        <i class="asterisk icon"></i>
    </div>
    <textarea rows="2" style="padding-left: 2.5em !important;"></textarea>
</div>

image

@lubber-de lubber-de added type/bug Any issue which is a bug or PR which fixes a bug lang/css Anything involving CSS labels Nov 30, 2018
@lubber-de lubber-de self-assigned this Nov 30, 2018
@lubber-de lubber-de added this to the 2.7.0 milestone Nov 30, 2018
@lubber-de lubber-de added the type/feat Any feature requests or improvements label Nov 30, 2018
@lubber-de lubber-de removed the type/bug Any issue which is a bug or PR which fixes a bug label Nov 30, 2018
@lubber-de
Copy link
Member

I labeled this an enhancement instead of a bug, because basically input was not designed to support textarea that way. But it is a nice addition and was not complex to add, so thanks for the idea, it is supposed to be in the next release 😉

@perezdev
Copy link
Author

@lubber-de

Ah. That makes sense. That explains why I didn't find references to textarea. Haha. Thanks a lot for adding it.

@lubber-de lubber-de added the tag/next-release/nightly Any issue which has a corresponding PR which has been merged and is available in the nightly build label Dec 3, 2018
This was referenced Dec 21, 2018
@y0hami y0hami closed this as completed Dec 21, 2018
@lubber-de lubber-de removed the tag/next-release/nightly Any issue which has a corresponding PR which has been merged and is available in the nightly build label Dec 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang/css Anything involving CSS type/feat Any feature requests or improvements
Projects
None yet
Development

No branches or pull requests

3 participants