-
-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2.7 Release #320
Merged
2.7 Release #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ame space as a real image should
…prevent form submission
Removed HTML to keep consistency across GitHub and package websites like npm and yarn. Also adds new jsDelivr badge.
Closes #112
This one needs a bit of explanation: The main cause of this bug was introduced in 2014 by Semantic-Org/Semantic-UI@400949c It was related to issue Semantic-Org/Semantic-UI#1510, where it seemed to be fixed but the main cause was the `collapsing` class set to the cell column, which causes the width to be reduced to 1px to force the browser to reduce its width until the main occupied content got the minimum width. So, this PR actually reverts the fix for Semantic-Org/Semantic-UI#1510 and fixes the main cause correctly now. Closes #227
Add inverted variant, basic grouping and basic tag as well as some bug fixes and code clean up. Closes #116
Change `event-stream` version to fix security exploit. Refs: dominictarr/event-stream#116 dominictarr/event-stream#115 Closes #268
Closes 194
… onHide()=false Closes #284
After using a prompt, the next gulp task hangs. Because we don't really need the prompt to be executed in a gulp pipe, we can just use Inquirer.js directly. Closes #307
ColinFrick
previously approved these changes
Dec 21, 2018
lubber-de
approved these changes
Dec 21, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, awesome release 😀
ColinFrick
approved these changes
Dec 21, 2018
This was referenced Jan 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version 2.7.0 - December 21, 2018
Announcement
With 2019 around the corner and a lot of discussion we (core contributors) have agreed to move our core focus to FUI v3.0. This doesn't mean we won't be working on 2.x but means releases may be slowed down a little due to more work being put into v3.0. You can read more about the future of FUI and v3.0 here
NOTES:
prompt-sui
which removes the child dependency ofevent-stream
this ensures that the library won't be downloading any (now deprecated) malicious code. If you want to learn more about the recent security issues withevent-stream
please read this issue.!important
usage which inturn produced lots of issues. Now with a big help from our core contributors we have removed ~85% of the usage and reduced the complexity of a lot of the color code base which makes it easier to make changes and helps reduce the size of the general code base aswell as removing duplicate code.Major Enhancements
Enhancements
Bugs
gulp build
when using newer versions of node Thanks @ColinFrick #307allowAdditions
Thanks @lubber-de #250onHide
returnedfalse
whenallowMultiple
wastrue
Thanks @lubber-de #284addTouchEvents
Thanks @lubber-de #278image icon
getting wrong height applied Thanks @lubber-de #248Security
prompt-sui
which inturn removesevent-stream
Thanks @ColinFrick #309