Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dropdown] Clearable dropdown initialized with a select always show the remove icon #271

Closed
prudho opened this issue Nov 28, 2018 · 0 comments
Closed

[Dropdown] Clearable dropdown initialized with a select always show the remove icon #271

prudho opened this issue Nov 28, 2018 · 0 comments
Assignees
@lubber-de
Labels
lang/css Anything involving CSS type/bug Any issue which is a bug or PR which fixes a bug
Milestone
2.7.0

Comments

@prudho
Copy link
Contributor

prudho commented Nov 28, 2018

Bug Report

Expected result

A none selected dropdown without any remove icon.

Actual result

A none selected dropdown with a remove icon, which is not correct.

Testcase

https://jsfiddle.net/zw349kst/

Screenshot

456fb1e63237290d1145ca8379a7298d.png

Version

2.6.4

Primary analysis

The css selector for hiding the remove icon is not valid when the dropdown is initialized from a select. Start investigating here: /src/definitions/modules/dropdown.less#L650.
@prudho prudho added type/bug Any issue which is a bug or PR which fixes a bug lang/css Anything involving CSS tag/help-wanted Issues which need help to fix or implement labels Nov 28, 2018
@prudho prudho added this to the 2.7.x milestone Nov 28, 2018
@lubber-de lubber-de self-assigned this Nov 28, 2018
@lubber-de lubber-de mentioned this issue Nov 28, 2018
Merged
@lubber-de lubber-de removed the tag/help-wanted Issues which need help to fix or implement label Nov 28, 2018
y0hami pushed a commit that referenced this issue Dec 3, 2018
@lubber-de
fix(dropdown): fix select always showing remove icon
652c99d 
Closes #271
@lubber-de lubber-de modified the milestones: 2.7.x, 2.7.0 Dec 3, 2018
@lubber-de lubber-de added the tag/next-release/nightly Any issue which has a corresponding PR which has been merged and is available in the nightly build label Dec 3, 2018
y0hami pushed a commit that referenced this issue Dec 18, 2018
@lubber-de
fix(dropdown): fix select always showing remove icon
024b7d6 
Closes #271
This was referenced Dec 21, 2018
Merged
Merged
@y0hami y0hami closed this as completed in 1334a27 Dec 21, 2018
@lubber-de lubber-de removed the tag/next-release/nightly Any issue which has a corresponding PR which has been merged and is available in the nightly build label Dec 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lubber-de lubber-de

Labels
lang/css Anything involving CSS type/bug Any issue which is a bug or PR which fixes a bug
Projects
None yet
Milestone
2.7.0
Development

No branches or pull requests
2 participants
@prudho @lubber-de