-
-
Notifications
You must be signed in to change notification settings - Fork 336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Rating] Individual icons and colors instead of fixed star+heart only #303
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I'm the original reporter of the issue in semantic-ui project. I'm just thrilled beyond words on how quickly this was solved. I just wish semantic-ui-react changes to fomantic. I'm using sui-react and found out that this needed fixing in sui. I had no hope this would be addressed as the original issue was reported in 2016 in sui repo and you guys added this capability in 10 days! Amazing work! @lubber-de @ColinFrick @hammy2899 Thank you! |
Description
This PR provides the possibility to use any icon or color to be used in a rating instead of the previously hardcoded star or heart rating
Usage
The icon can be defined either as data-attribute
data-icon
or as the JS parameter
icon
The color can be provided as usual as a classname from the current color palette:
ui green rating
Screenshot
Closes
Semantic-Org/Semantic-UI#6710
Semantic-Org/Semantic-UI#2399