-
-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Colors] Central dynamic color map for every component #261
Conversation
…ough and color palette naming is dynamic
I think this is an excellent start and I think you should start moving the other components into this format. Great work @lubber-de 👍 |
@hammy2899 Thanks 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with @hammy2899, this is a great addition !
… and tertiary accordingly
…hadow entries fixed.
This PR is ready for review now 😊 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Docs added by fomantic/Fomantic-UI-Docs#377 |
Description
This PR provides the base to create a central dynamic color palette in a single mixin-map instead of hardcoding every possible color in each component.
To stay backward compatible, this map currently holds the already existing global color variables.
Now it's possible to define only the colors and naming you want and each component will generate the appropriate component with the colors and those namings which are defined in the central map.
This way it's now easy to define completely new color-names without touching any component manually.
Example
If somebody does not like the basic FUI color palette but want to use only brand color namings instead, the
colors.less
needs to be created in the appropriate{site}
folder of the theme folder having this example content:Now only those color names
pinkiepie
andtwilight
are available and compiled into the whole framework instead of the FUI default ones. You would be able to use everything likeui pinkiepie button
ui twilight segment
and so on...Using this feature requires LESS >= v3.7
!important
replaced by proper specificity 🙂!important
replaced by proper specificity 🙂!important
replaced by proper specificity 🙂!important
removed (was not needed)!important
removed (was not needed), added cell color support!important
removed (was not needed)!important
removed (was not needed)Github Tasklist Overview
To be able to see open tasks counter in the Issues Overview
Screenshots
New Text component limited to
span
tags as discussed in #289Table Cell color support
Relates to
Semantic-Org/Semantic-UI#6673
Semantic-Org/Semantic-UI#6661
Semantic-Org/Semantic-UI#6193
Semantic-Org/Semantic-UI#2279
Semantic-Org/Semantic-UI#4650