Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dropdown, Input, Loader] Elastic Animation Style had wrong color #324

Closed
wants to merge 56 commits into from

Conversation

lubber-de
Copy link
Member

@lubber-de lubber-de commented Dec 23, 2018

Description

  • Elastic Loader in dropdown/input misses correct color setting in :before tag.
  • Also changed the static @grey or @white variables to the loader specific variables @loaderLineColorand @invertedLoaderLineColor instead. Infact the color is the same on the default theme, but using the loader specific variables is now more safe regarding the new central color mixing usage from [Colors] Central dynamic color map for every component #261

Testcase

https://fomantic-ui.com/modules/dropdown.html#loading
https://fomantic-ui.com/elements/input.html#loading

Fix

Comment out the css part to see the issue again
http://jsfiddle.net/015dbk4t/1/

Screenshot

Before

elastic_dropdown_loading

After

elastic_dropdown_loading_fix

Version

2.7.0

lubber-de and others added 30 commits November 15, 2018 08:50
Removed HTML to keep consistency across GitHub and package websites like npm and yarn.
Also adds new jsDelivr badge.
This one needs a bit of explanation:
The main cause of this bug was introduced in 2014 by Semantic-Org/Semantic-UI@400949c
It was related to issue Semantic-Org/Semantic-UI#1510, where it seemed to be fixed but the main cause was the `collapsing` class set to the cell column, which causes the width to be reduced to 1px to force the browser to reduce its width until the main occupied content got the minimum width.
So, this PR actually reverts the fix for Semantic-Org/Semantic-UI#1510 and fixes the main cause correctly now.

Closes fomantic#227
Add inverted variant, basic grouping and basic tag as
well as some bug fixes and code clean up.

Closes fomantic#116
@lubber-de lubber-de added lang/css Anything involving CSS 🐛 bugfix labels Dec 23, 2018
@lubber-de lubber-de added this to the 2.7.x milestone Dec 23, 2018
@lubber-de lubber-de added the state/awaiting-reviews Pull requests which are waiting for reviews label Dec 23, 2018
@lubber-de lubber-de changed the title [Dropdown, Loader] Elastic Animation Style had wrong color [Dropdown, Input, Loader] Elastic Animation Style had wrong color Dec 23, 2018
@lubber-de lubber-de closed this Dec 23, 2018
@lubber-de lubber-de deleted the fix/elastic_dropdown branch December 23, 2018 21:18
@lubber-de lubber-de removed this from the 2.7.x milestone Dec 23, 2018
@lubber-de lubber-de added type/duplicate Anything which is a duplicate and removed 🐛 bugfix state/awaiting-reviews Pull requests which are waiting for reviews lang/css Anything involving CSS labels Dec 23, 2018
@lubber-de
Copy link
Member Author

messed up base branch... new PR is #325

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/duplicate Anything which is a duplicate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants