-
-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Dropdown, Input, Loader] Elastic Animation Style had wrong color #324
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ame space as a real image should
…prevent form submission
Removed HTML to keep consistency across GitHub and package websites like npm and yarn. Also adds new jsDelivr badge.
This one needs a bit of explanation: The main cause of this bug was introduced in 2014 by Semantic-Org/Semantic-UI@400949c It was related to issue Semantic-Org/Semantic-UI#1510, where it seemed to be fixed but the main cause was the `collapsing` class set to the cell column, which causes the width to be reduced to 1px to force the browser to reduce its width until the main occupied content got the minimum width. So, this PR actually reverts the fix for Semantic-Org/Semantic-UI#1510 and fixes the main cause correctly now. Closes fomantic#227
Add inverted variant, basic grouping and basic tag as well as some bug fixes and code clean up. Closes fomantic#116
Change `event-stream` version to fix security exploit. Refs: dominictarr/event-stream#116 dominictarr/event-stream#115 Closes fomantic#268
Closes 194
… onHide()=false Closes fomantic#284
lubber-de
added
the
state/awaiting-reviews
Pull requests which are waiting for reviews
label
Dec 23, 2018
lubber-de
changed the title
[Dropdown, Loader] Elastic Animation Style had wrong color
[Dropdown, Input, Loader] Elastic Animation Style had wrong color
Dec 23, 2018
lubber-de
added
type/duplicate
Anything which is a duplicate
and removed
🐛 bugfix
state/awaiting-reviews
Pull requests which are waiting for reviews
lang/css
Anything involving CSS
labels
Dec 23, 2018
messed up base branch... new PR is #325 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
@grey
or@white
variables to the loader specific variables@loaderLineColor
and@invertedLoaderLineColor
instead. Infact the color is the same on the default theme, but using the loader specific variables is now more safe regarding the new central color mixing usage from [Colors] Central dynamic color map for every component #261Testcase
https://fomantic-ui.com/modules/dropdown.html#loading
https://fomantic-ui.com/elements/input.html#loading
Fix
Comment out the css part to see the issue again
http://jsfiddle.net/015dbk4t/1/
Screenshot
Before
After
Version
2.7.0