Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Question][label input] No red border around label with error class #257

Closed
hakeem86 opened this issue Nov 23, 2018 · 2 comments
Closed

[Question][label input] No red border around label with error class #257

hakeem86 opened this issue Nov 23, 2018 · 2 comments
Assignees
@prudho
Labels
lang/css Anything involving CSS type/feat Any feature requests or improvements
Milestone
2.7.0

Comments

@hakeem86
Copy link

Hi,

This might be by design, but shouldn't there be a red border around the label? the background still same color, but a red border around the label?

https://jsfiddle.net/2crxvkua/
@y0hami
Copy link
Member

y0hami commented Nov 23, 2018

This is definitely by design but maybe it possibly should show the error too.

@y0hami y0hami added type/feat Any feature requests or improvements lang/css Anything involving CSS tag/help-wanted Issues which need help to fix or implement tag/good-first-issue Good issues for new starters to try labels Nov 23, 2018
@y0hami y0hami added this to the 2.7.x milestone Nov 23, 2018
@hakeem86
Copy link
Author

I personally prefer the first one.

https://jsfiddle.net/v1yzrmjd/

@prudho prudho self-assigned this Nov 28, 2018
@prudho prudho mentioned this issue Nov 28, 2018
Merged
y0hami pushed a commit that referenced this issue Nov 28, 2018
@prudho
feat(input): add red border around error labeled input
4f34d88 
Closes #257
@lubber-de lubber-de added tag/next-release/nightly Any issue which has a corresponding PR which has been merged and is available in the nightly build and removed tag/good-first-issue Good issues for new starters to try tag/help-wanted Issues which need help to fix or implement labels Nov 28, 2018
@lubber-de lubber-de modified the milestones: 2.7.x, 2.7.0 Nov 28, 2018
y0hami pushed a commit that referenced this issue Dec 18, 2018
@prudho
feat(input): add red border around error labeled input
6865e08 
Closes #257
This was referenced Dec 21, 2018
Merged
Merged
@y0hami y0hami closed this as completed in 5098f2a Dec 21, 2018
@lubber-de lubber-de removed the tag/next-release/nightly Any issue which has a corresponding PR which has been merged and is available in the nightly build label Dec 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@prudho prudho

Labels
lang/css Anything involving CSS type/feat Any feature requests or improvements
Projects
None yet
Milestone
2.7.0
Development

No branches or pull requests
4 participants
@prudho @hakeem86 @y0hami @lubber-de