Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(input): add red border around error labeled input #270

Merged
merged 2 commits into from
Nov 28, 2018
Merged

feat(input): add red border around error labeled input #270

merged 2 commits into from
Nov 28, 2018

Conversation

prudho
Copy link
Contributor

@prudho prudho commented Nov 28, 2018

Description

This PR adds a red border around error labeled input, following @hakeem86 advice.

Testcase

jsfiddle

Screenshot

06dcee4062750cc22354073088eb0e29.png

Closes

#257

@prudho prudho added type/feat Any feature requests or improvements lang/css Anything involving CSS state/awaiting-reviews Pull requests which are waiting for reviews labels Nov 28, 2018
@prudho prudho added this to the 2.7.x milestone Nov 28, 2018
@prudho prudho self-assigned this Nov 28, 2018
y0hami
y0hami approved these changes Nov 28, 2018
View reviewed changes
Copy link
Member

@y0hami y0hami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lubber-de
lubber-de approved these changes Nov 28, 2018
View reviewed changes
Copy link
Member

@lubber-de lubber-de left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@y0hami y0hami removed the state/awaiting-reviews Pull requests which are waiting for reviews label Nov 28, 2018
@y0hami y0hami merged commit 4f34d88 into fomantic:develop Nov 28, 2018
@prudho prudho deleted the fix-257 branch November 28, 2018 13:10
@lubber-de lubber-de modified the milestones: 2.7.x, 2.7.0 Nov 28, 2018
@lubber-de lubber-de mentioned this pull request Dec 28, 2018
Merged
@lubber-de lubber-de mentioned this pull request May 7, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lubber-de lubber-de lubber-de approved these changes

@y0hami y0hami y0hami approved these changes

@ColinFrick ColinFrick Awaiting requested review from ColinFrick

Assignees

@prudho prudho

Labels
lang/css Anything involving CSS type/feat Any feature requests or improvements
Projects
None yet
Milestone
2.7.0
Development

Successfully merging this pull request may close these issues.
3 participants
@prudho @y0hami @lubber-de