Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Input] Support error class on input action buttons #329

Merged
merged 1 commit into from
Dec 31, 2018

Conversation

lubber-de
Copy link
Member

Description

In addtion to the enhancement from @prudho , this PR also adds support for input action buttons being surrounded by the error border

Testcase

https://jsfiddle.net/o0c6mk6u/2/

Screenshot

Before

image

After

image

Related

#270

Closes

Semantic-Org/Semantic-UI#5670

@lubber-de lubber-de added type/feat Any feature requests or improvements lang/css Anything involving CSS state/awaiting-reviews Pull requests which are waiting for reviews labels Dec 28, 2018
@lubber-de lubber-de added this to the 2.7.x milestone Dec 28, 2018
Copy link
Member

@ColinFrick ColinFrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@prudho prudho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lubber-de lubber-de added the tag/sui-issue Taken from an existing Issue/PR of SUI label Dec 31, 2018
@y0hami y0hami merged commit 3cbc515 into fomantic:develop Dec 31, 2018
@y0hami y0hami removed the state/awaiting-reviews Pull requests which are waiting for reviews label Dec 31, 2018
@lubber-de lubber-de modified the milestones: 2.7.x, 2.7.2 Dec 31, 2018
@lubber-de lubber-de deleted the fix/5670/error_input_action branch December 31, 2018 18:39
@y0hami y0hami mentioned this pull request Feb 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang/css Anything involving CSS tag/sui-issue Taken from an existing Issue/PR of SUI type/feat Any feature requests or improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants