-
-
Notifications
You must be signed in to change notification settings - Fork 336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Loader] Centralised, Double+Elastic, other modules supported and dimmer option added #301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… components (dropdown, search, tab, segment, button, input, form. Also fixed tab loading position
…ed segments or tabs
…with other 'variation' for the meaning of additional classes
…o enhanced_loader
…o enhanced_loader
…o enhanced_loader
…o enhanced_loader
…o enhanced_loader
lubber-de
added
type/feat
Any feature requests or improvements
lang/css
Anything involving CSS
lang/javascript
Anything involving JavaScript
tag/new-component
New UI components
state/awaiting-reviews
Pull requests which are waiting for reviews
labels
Dec 15, 2018
lubber-de
added
the
state/awaiting-docs
Pull requests which need doc changes/additions
label
Dec 15, 2018
17 tasks
y0hami
requested changes
Dec 16, 2018
y0hami
approved these changes
Dec 18, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@lubber-de These conflicts will need fixed 😉 |
# Conflicts: # src/definitions/collections/form.less # src/definitions/elements/input.less # src/definitions/elements/loader.less # src/definitions/elements/segment.less # src/definitions/modules/search.less # src/definitions/modules/tab.less
Solved the conflicts, it's mergeable into develop again |
ColinFrick
approved these changes
Dec 20, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
y0hami
removed
the
state/awaiting-reviews
Pull requests which are waiting for reviews
label
Dec 20, 2018
lubber-de
added
state/has-docs
A issue/PR which requires documentation changes and has the corresponding PR open in the docs repo
and removed
state/awaiting-docs
Pull requests which need doc changes/additions
labels
Dec 21, 2018
This was referenced Dec 21, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
lang/css
Anything involving CSS
lang/javascript
Anything involving JavaScript
state/has-docs
A issue/PR which requires documentation changes and has the corresponding PR open in the docs repo
tag/new-component
New UI components
type/feat
Any feature requests or improvements
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR centralises the loader-element css code, adds new variations
double
andelastic
of the loading animation and adds new loader options todimmer
loading
variants ofdropdown
,search
,tab
,segment
,button
,input
andform
double
which is basically the same as the usual loader, but has 2 colored parts of the circleelastic
. You know this common animation from everywhere 😉 It's also supportedeverywhere* in combination of any color or speed.
Examples
Variant
double
Variant
elastic
Usage in Form
Usage in Dimmer
New Dimmer options
The dimmer has been enhanced to use the new features at runtime aswell. Three options were added
loaderText
-> Text to display underneath the LoaderloaderVariation
-> To add desired loader variation classesdisplayLoader
-> If a loader should be displayed on the dimmerUsage in segment
As you already can specify a color to a segment to color its top border, by default an added
loading
class to a segment will automatically be displayed in the same color.If you do not want this, then add
usual
to your loading definition and the loader inside the segment will be displayed as before