[Checkbox] Support onChange for cursor keynav #295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lubber-de
added
type/bug
|
You can change the value of a radio box with the keyboard even if Option 2 is "disabled": |
y0hami
added
🐛 bugfix
and removed
type/bug
…not allow to be checked
|
@ColinFrick 😮 That was quite challenging, but keynav is now stopped if next option does not allow to be checked or current option does not allow to be unchecked |
ColinFrick
approved these changes
Dec 13, 2018
prudho
approved these changes
Dec 13, 2018
y0hami
removed
state/awaiting-reviews
This was referenced Dec 21, 2018
Merged
This was referenced Jan 17, 2019
y0hami
pushed a commit
that referenced
this pull request
Jan 28, 2019
The keypoint here is, that this PR basically fixes a very old behavior in SUI: According to the docs the behaviors `set checked|unchecked|enabled|disabled|determinate|indeterminate` are not supposed to run callbacks. But they actually always did (!) They ever since triggered the `change event`, but it never had any impact, just because the module itself did not have any `onChange` event until #295 That said, in conclusion the onchange event was now called twice: In the `set` methods aswell as in the `module` methods. 😞 The onChange event has to be kept, otherwise the keynav will not notify any change to the event system, so i removed the (wrong) event triggering in the above mentioned behavior functions and put them outside instead. In addition i also hotfixed #295, because the beforeChecked/Unchecked methods were not called correctly Closes #399, #400
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changing Radio-Button Selections via Cursor Key-Navigation was not triggering the onChange Event
Testcase
Unfixed
https://jsfiddle.net/n9sLf81w/
Fixed
https://jsfiddle.net/ujkdreqs/
Closes
Semantic-Org/Semantic-UI#6676