-
-
Notifications
You must be signed in to change notification settings - Fork 336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Build Tools] update to gulp4 #179
Conversation
…ions directly in series, remove internal task collection
Great work @ColinFrick, I will try and get some testing done in the next few days. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have tested most used commands (install, build, watch...) without getting any warning or error. I have checked code and everything looks fine.
Bonus point, Travis built the whole PR all by itself, smoothly.
This is a great job, LGTM 👍
I just did some quick testing and found this error
Steps:
|
Weird because I didn’t really change install I’ll look into it as soon as I’m home |
As I suspected this is a pre-existing problem. Just tested this on How should we proceed with this problem? This should only affect users who clone the repository, and don't use fomantic-ui throughb npm. |
Is there a way to check if |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Great work! Much appreciated. 👍
Description
Update all dependencies with gulp 4
Admin package was updated, but was not tested
Closes
#112 / Semantic-Org/Semantic-UI#6549 / Semantic-Org/Semantic-UI#3793