Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Message] fixed compact icon message width #279

Merged
merged 6 commits into from
Dec 3, 2018
Merged

[Message] fixed compact icon message width #279

merged 6 commits into from
Dec 3, 2018

Conversation

lubber-de
Copy link
Member

@lubber-de lubber-de commented Dec 1, 2018 •
edited
Loading

Description

compact icon message still had 100% width. Fixed by adding auto

Testcase

http://jsfiddle.net/95kzk6mr/2/

Screenshot

Before

image

After

image

Closes

Semantic-Org/Semantic-UI#4759
Semantic-Org/Semantic-UI-React#2280

@lubber-de lubber-de added type/bug Any issue which is a bug or PR which fixes a bug lang/css Anything involving CSS state/awaiting-reviews Pull requests which are waiting for reviews tag/sui-issue Taken from an existing Issue/PR of SUI labels Dec 1, 2018
@lubber-de lubber-de added this to the 2.7.0 milestone Dec 1, 2018
y0hami
y0hami approved these changes Dec 1, 2018
View reviewed changes
Copy link
Member

@y0hami y0hami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ColinFrick
ColinFrick approved these changes Dec 3, 2018
View reviewed changes
Copy link
Member

@ColinFrick ColinFrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@y0hami y0hami merged commit 536a5c1 into fomantic:develop Dec 3, 2018
@y0hami y0hami removed state/awaiting-reviews Pull requests which are waiting for reviews labels Dec 3, 2018
@lubber-de lubber-de deleted the fix/4759/compact_icon_message_width branch December 3, 2018 11:13
This was referenced Dec 21, 2018
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@y0hami y0hami y0hami approved these changes

@ColinFrick ColinFrick ColinFrick approved these changes

@prudho prudho Awaiting requested review from prudho

Assignees
No one assigned
Labels
lang/css Anything involving CSS tag/sui-issue Taken from an existing Issue/PR of SUI type/bug Any issue which is a bug or PR which fixes a bug
Projects
None yet
Milestone
2.7.0
Development

Successfully merging this pull request may close these issues.
3 participants
@lubber-de @ColinFrick @y0hami