Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CSS] Fix some errors #275

Merged
merged 16 commits into from
Dec 7, 2018
Merged

[CSS] Fix some errors #275

merged 16 commits into from
Dec 7, 2018

Conversation

prudho
Copy link
Contributor

@prudho prudho commented Nov 30, 2018

Following #274.

Most of theses error are wrong css properties or values

@prudho prudho added lang/css Anything involving CSS state/awaiting-reviews Pull requests which are waiting for reviews 🐛 bugfix labels Nov 30, 2018
@prudho prudho added this to the 2.7.x milestone Nov 30, 2018
@prudho prudho self-assigned this Nov 30, 2018
y0hami
y0hami requested changes Nov 30, 2018
View reviewed changes
src/definitions/elements/label.less Outdated Show resolved Hide resolved
src/definitions/elements/step.less Show resolved Hide resolved
y0hami
y0hami approved these changes Dec 7, 2018
View reviewed changes
Copy link
Member

@y0hami y0hami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lubber-de
lubber-de approved these changes Dec 7, 2018
View reviewed changes
Copy link
Member

@lubber-de lubber-de left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@y0hami y0hami merged commit 991a195 into fomantic:develop Dec 7, 2018
@y0hami y0hami removed state/awaiting-reviews Pull requests which are waiting for reviews labels Dec 17, 2018
This was referenced Dec 21, 2018
Merged
Merged
@lubber-de lubber-de modified the milestones: 2.7.x, 2.7.0 Feb 28, 2019
@prudho prudho deleted the fix-274 branch April 11, 2019 13:00
@exoego exoego added type/bug Any issue which is a bug or PR which fixes a bug and removed 🐛 bugfix labels May 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@y0hami y0hami y0hami approved these changes

@lubber-de lubber-de lubber-de approved these changes

@ColinFrick ColinFrick Awaiting requested review from ColinFrick

Assignees

@prudho prudho

Labels
lang/css Anything involving CSS type/bug Any issue which is a bug or PR which fixes a bug
Projects
None yet
Milestone
2.7.0
Development

Successfully merging this pull request may close these issues.
4 participants
@prudho @y0hami @lubber-de @exoego