[Popup] Fix correct usage for addTouchEvents=false #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lubber-de
added
type/bug
y0hami
removed
state/awaiting-reviews
This was referenced Dec 21, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The setting
addTouchEventswas not even implemented.The idea behind this setting should always have been to disable hover popups on mobile, when
addTouchEvents:false, which works now.Infact popup now always allows the touchevent, but primary only to find out if the device is a touch device or not (touchstart is triggered before mouseenter). The addTouchEvents parameter is now used to decide if the popoup should be shown on hover on touch devices or not.
Testcase
Open the following links in a real mobile browser to reproduce the issue and the fix
Click somewhere in the Message Area (works best, when you click in empty areas around the text):
Unfixed version
http://jsfiddle.net/2hm3nmLx/5/show
Fixed version
http://jsfiddle.net/2hm3nmLx/7/show
Closes
Semantic-Org/Semantic-UI#3382
Semantic-Org/Semantic-UI#5524