Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Global]: Remove deprecated jquery functions #282

Merged
merged 2 commits into from
Dec 7, 2018
Merged

[Global]: Remove deprecated jquery functions #282

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d41f315
feat(global): Remove deprecated jquery functions (own $.isFunction an…
lubber-de Dec 3, 2018
9a5a4e9
feat(global): Moved deprecated jquery functions to every single compo…
lubber-de Dec 4, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/definitions/behaviors/api.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -990,7 +990,7 @@ $.api = $.fn.api = function(parameters) {
else if(found !== undefined) {
response = found;
}
if($.isArray(returnedValue)) {
if(Array.isArray(returnedValue)) {
returnedValue.push(response);
}
else if(returnedValue !== undefined) {
Expand Down
20 changes: 10 additions & 10 deletions src/definitions/behaviors/form.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,7 +261,7 @@ $.fn.form = function(parameters) {
},
// duck type rule test
shorthandRules: function(rules) {
return (typeof rules == 'string' || $.isArray(rules));
return (typeof rules == 'string' || Array.isArray(rules));
},
empty: function($field) {
if(!$field || $field.length === 0) {
Expand Down Expand Up @@ -565,7 +565,7 @@ $.fn.form = function(parameters) {
},
values: function (fields) {
var
$fields = $.isArray(fields)
$fields = Array.isArray(fields)
? module.get.fields(fields)
: $field,
values = {}
Expand Down Expand Up @@ -667,7 +667,7 @@ $.fn.form = function(parameters) {
newValidation = {}
;
if(module.is.shorthandRules(rules)) {
rules = $.isArray(rules)
rules = Array.isArray(rules)
? rules
: [rules]
;
Expand Down Expand Up @@ -750,7 +750,7 @@ $.fn.form = function(parameters) {
remove: {
rule: function(field, rule) {
var
rules = $.isArray(rule)
rules = Array.isArray(rule)
? rule
: [rule]
;
Expand All @@ -759,7 +759,7 @@ $.fn.form = function(parameters) {
validation[field].rules = [];
return;
}
if(validation[field] == undefined || !$.isArray(validation[field].rules)) {
if(validation[field] == undefined || !Array.isArray(validation[field].rules)) {
return;
}
$.each(validation[field].rules, function(index, rule) {
Expand All @@ -771,7 +771,7 @@ $.fn.form = function(parameters) {
},
field: function(field) {
var
fields = $.isArray(field)
fields = Array.isArray(field)
? field
: [field]
;
Expand All @@ -781,7 +781,7 @@ $.fn.form = function(parameters) {
},
// alias
rules: function(field, rules) {
if($.isArray(field)) {
if(Array.isArray(field)) {
$.each(fields, function(index, field) {
module.remove.rule(field, rules);
});
Expand Down Expand Up @@ -862,7 +862,7 @@ $.fn.form = function(parameters) {
var
$field = module.get.field(key),
$element = $field.parent(),
isMultiple = $.isArray(value),
isMultiple = Array.isArray(value),
isCheckbox = $element.is(selector.uiCheckbox),
isDropdown = $element.is(selector.uiDropdown),
isRadio = ($field.is(selector.radio) && isCheckbox),
Expand Down Expand Up @@ -1180,7 +1180,7 @@ $.fn.form = function(parameters) {
else if(found !== undefined) {
response = found;
}
if($.isArray(returnedValue)) {
if(Array.isArray(returnedValue)) {
returnedValue.push(response);
}
else if(returnedValue !== undefined) {
Expand Down Expand Up @@ -1336,7 +1336,7 @@ $.fn.form.settings = {

// is not empty or blank string
empty: function(value) {
return !(value === undefined || '' === value || $.isArray(value) && value.length === 0);
return !(value === undefined || '' === value || Array.isArray(value) && value.length === 0);
},

// checkbox checked
Expand Down
2 changes: 1 addition & 1 deletion src/definitions/behaviors/state.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -559,7 +559,7 @@ $.fn.state = function(parameters) {
else if(found !== undefined) {
response = found;
}
if($.isArray(returnedValue)) {
if(Array.isArray(returnedValue)) {
returnedValue.push(response);
}
else if(returnedValue !== undefined) {
Expand Down
2 changes: 1 addition & 1 deletion src/definitions/behaviors/visibility.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1172,7 +1172,7 @@ $.fn.visibility = function(parameters) {
else if(found !== undefined) {
response = found;
}
if($.isArray(returnedValue)) {
if(Array.isArray(returnedValue)) {
returnedValue.push(response);
}
else if(returnedValue !== undefined) {
Expand Down
9 changes: 8 additions & 1 deletion src/definitions/globals/site.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,13 @@

;(function ($, window, document, undefined) {

$.isFunction = $.isFunction || function(obj) {
lubber-de marked this conversation as resolved.
Show resolved Hide resolved
return typeof obj === "function" && typeof obj.nodeType !== "number";
};
$.isWindow = $.isWindow || function(obj) {
return obj != null && obj === obj.window;
};

$.site = $.fn.site = function(parameters) {
var
time = new Date().getTime(),
Expand Down Expand Up @@ -391,7 +398,7 @@ $.site = $.fn.site = function(parameters) {
else if(found !== undefined) {
response = found;
}
if($.isArray(returnedValue)) {
if(Array.isArray(returnedValue)) {
returnedValue.push(response);
}
else if(returnedValue !== undefined) {
Expand Down
2 changes: 1 addition & 1 deletion src/definitions/modules/accordion.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -522,7 +522,7 @@ $.fn.accordion = function(parameters) {
else if(found !== undefined) {
response = found;
}
if($.isArray(returnedValue)) {
if(Array.isArray(returnedValue)) {
returnedValue.push(response);
}
else if(returnedValue !== undefined) {
Expand Down
2 changes: 1 addition & 1 deletion src/definitions/modules/calendar.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1042,7 +1042,7 @@ $.fn.calendar = function(parameters) {
else if (found !== undefined) {
response = found;
}
if ($.isArray(returnedValue)) {
if (Array.isArray(returnedValue)) {
returnedValue.push(response);
}
else if (returnedValue !== undefined) {
Expand Down
2 changes: 1 addition & 1 deletion src/definitions/modules/checkbox.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -735,7 +735,7 @@ $.fn.checkbox = function(parameters) {
else if(found !== undefined) {
response = found;
}
if($.isArray(returnedValue)) {
if(Array.isArray(returnedValue)) {
returnedValue.push(response);
}
else if(returnedValue !== undefined) {
Expand Down
2 changes: 1 addition & 1 deletion src/definitions/modules/dimmer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -622,7 +622,7 @@ $.fn.dimmer = function(parameters) {
else if(found !== undefined) {
response = found;
}
if($.isArray(returnedValue)) {
if(Array.isArray(returnedValue)) {
returnedValue.push(response);
}
else if(returnedValue !== undefined) {
Expand Down
24 changes: 12 additions & 12 deletions src/definitions/modules/dropdown.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,7 @@ $.fn.dropdown = function(parameters) {
if(!values) {
return false;
}
values = $.isArray(values)
values = Array.isArray(values)
? values
: [values]
;
Expand Down Expand Up @@ -774,7 +774,7 @@ $.fn.dropdown = function(parameters) {
onSuccess : function(response) {
var
values = response[fields.remoteValues],
hasRemoteValues = ($.isArray(values) && values.length > 0)
hasRemoteValues = (Array.isArray(values) && values.length > 0)
;
if(hasRemoteValues) {
module.remove.message();
Expand Down Expand Up @@ -1752,7 +1752,7 @@ $.fn.dropdown = function(parameters) {
count
;
count = ( module.is.multiple() )
? $.isArray(values)
? Array.isArray(values)
? values.length
: 0
: (module.get.value() !== '')
Expand All @@ -1776,7 +1776,7 @@ $.fn.dropdown = function(parameters) {
if(!values) {
return false;
}
values = $.isArray(values)
values = Array.isArray(values)
? values
: [values]
;
Expand Down Expand Up @@ -1811,7 +1811,7 @@ $.fn.dropdown = function(parameters) {
value = ($input.length > 0)
? $input.val()
: $module.data(metadata.value),
isEmptyMultiselect = ($.isArray(value) && value.length === 1 && value[0] === '')
isEmptyMultiselect = (Array.isArray(value) && value.length === 1 && value[0] === '')
;
// prevents placeholder element from being selected when multiple
return (value === undefined || isEmptyMultiselect)
Expand Down Expand Up @@ -2002,7 +2002,7 @@ $.fn.dropdown = function(parameters) {
? (value.length > 0)
: (value !== undefined && value !== null)
;
isMultiple = (module.is.multiple() && $.isArray(value));
isMultiple = (module.is.multiple() && Array.isArray(value));
strict = (value === '' || value === 0)
? true
: strict || false
Expand Down Expand Up @@ -2830,7 +2830,7 @@ $.fn.dropdown = function(parameters) {
return;
}
// extend current array
if($.isArray(currentValue)) {
if(Array.isArray(currentValue)) {
newValue = currentValue.concat([addedValue]);
newValue = module.get.uniqueArray(newValue);
}
Expand Down Expand Up @@ -3015,7 +3015,7 @@ $.fn.dropdown = function(parameters) {
module.check.maxSelections();
},
arrayValue: function(removedValue, values) {
if( !$.isArray(values) ) {
if( !Array.isArray(values) ) {
values = [values];
}
values = $.grep(values, function(value){
Expand Down Expand Up @@ -3173,7 +3173,7 @@ $.fn.dropdown = function(parameters) {
valueMatchingCase: function(value) {
var
values = module.get.values(),
hasValue = $.isArray(values)
hasValue = Array.isArray(values)
? values && ($.inArray(value, values) !== -1)
: (values == value)
;
Expand All @@ -3187,7 +3187,7 @@ $.fn.dropdown = function(parameters) {
values = module.get.values(),
hasValue = false
;
if(!$.isArray(values)) {
if(!Array.isArray(values)) {
values = [values];
}
$.each(values, function(index, existingValue) {
Expand Down Expand Up @@ -3559,7 +3559,7 @@ $.fn.dropdown = function(parameters) {
escape: {
value: function(value) {
var
multipleValues = $.isArray(value),
multipleValues = Array.isArray(value),
stringValue = (typeof value === 'string'),
isUnparsable = (!stringValue && !multipleValues),
hasQuotes = (stringValue && value.search(regExp.quote) !== -1),
Expand Down Expand Up @@ -3733,7 +3733,7 @@ $.fn.dropdown = function(parameters) {
else if(found !== undefined) {
response = found;
}
if($.isArray(returnedValue)) {
if(Array.isArray(returnedValue)) {
returnedValue.push(response);
}
else if(returnedValue !== undefined) {
Expand Down
2 changes: 1 addition & 1 deletion src/definitions/modules/embed.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -541,7 +541,7 @@ $.fn.embed = function(parameters) {
else if(found !== undefined) {
response = found;
}
if($.isArray(returnedValue)) {
if(Array.isArray(returnedValue)) {
returnedValue.push(response);
}
else if(returnedValue !== undefined) {
Expand Down
2 changes: 1 addition & 1 deletion src/definitions/modules/modal.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -970,7 +970,7 @@ $.fn.modal = function(parameters) {
else if(found !== undefined) {
response = found;
}
if($.isArray(returnedValue)) {
if(Array.isArray(returnedValue)) {
returnedValue.push(response);
}
else if(returnedValue !== undefined) {
Expand Down
2 changes: 1 addition & 1 deletion src/definitions/modules/nag.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -405,7 +405,7 @@ $.fn.nag = function(parameters) {
else if(found !== undefined) {
response = found;
}
if($.isArray(returnedValue)) {
if(Array.isArray(returnedValue)) {
returnedValue.push(response);
}
else if(returnedValue !== undefined) {
Expand Down
2 changes: 1 addition & 1 deletion src/definitions/modules/popup.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1291,7 +1291,7 @@ $.fn.popup = function(parameters) {
else if(found !== undefined) {
response = found;
}
if($.isArray(returnedValue)) {
if(Array.isArray(returnedValue)) {
returnedValue.push(response);
}
else if(returnedValue !== undefined) {
Expand Down
2 changes: 1 addition & 1 deletion src/definitions/modules/progress.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -801,7 +801,7 @@ $.fn.progress = function(parameters) {
else if(found !== undefined) {
response = found;
}
if($.isArray(returnedValue)) {
if(Array.isArray(returnedValue)) {
returnedValue.push(response);
}
else if(returnedValue !== undefined) {
Expand Down
2 changes: 1 addition & 1 deletion src/definitions/modules/rating.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -418,7 +418,7 @@ $.fn.rating = function(parameters) {
else if(found !== undefined) {
response = found;
}
if($.isArray(returnedValue)) {
if(Array.isArray(returnedValue)) {
returnedValue.push(response);
}
else if(returnedValue !== undefined) {
Expand Down
10 changes: 5 additions & 5 deletions src/definitions/modules/search.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -445,7 +445,7 @@ $.fn.search = function(parameters) {
if(settings.type === 'category') {
module.debug('Finding result that matches', value);
$.each(results, function(index, category) {
if($.isArray(category.results)) {
if(Array.isArray(category.results)) {
result = module.search.object(value, category.results, lookupFields)[0];
// don't continue searching if a result is found
if(result) {
Expand Down Expand Up @@ -525,7 +525,7 @@ $.fn.search = function(parameters) {
}
else {
module.debug('Querying for', searchTerm);
if($.isPlainObject(settings.source) || $.isArray(settings.source)) {
if($.isPlainObject(settings.source) || Array.isArray(settings.source)) {
module.search.local(searchTerm);
callback();
}
Expand Down Expand Up @@ -611,7 +611,7 @@ $.fn.search = function(parameters) {
;

// search fields should be array to loop correctly
if(!$.isArray(searchFields)) {
if(!Array.isArray(searchFields)) {
searchFields = [searchFields];
}

Expand Down Expand Up @@ -1001,7 +1001,7 @@ $.fn.search = function(parameters) {
var
template = settings.templates[settings.type],
isProperObject = ($.isPlainObject(response[fields.results]) && !$.isEmptyObject(response[fields.results])),
isProperArray = ($.isArray(response[fields.results]) && response[fields.results].length > 0),
isProperArray = (Array.isArray(response[fields.results]) && response[fields.results].length > 0),
html = ''
;
if(isProperObject || isProperArray ) {
Expand Down Expand Up @@ -1182,7 +1182,7 @@ $.fn.search = function(parameters) {
else if(found !== undefined) {
response = found;
}
if($.isArray(returnedValue)) {
if(Array.isArray(returnedValue)) {
returnedValue.push(response);
}
else if(returnedValue !== undefined) {
Expand Down
2 changes: 1 addition & 1 deletion src/definitions/modules/shape.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -822,7 +822,7 @@ $.fn.shape = function(parameters) {
else if(found !== undefined) {
response = found;
}
if($.isArray(returnedValue)) {
if(Array.isArray(returnedValue)) {
returnedValue.push(response);
}
else if(returnedValue !== undefined) {
Expand Down
Loading