Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Label] Adjust image height of image labels in menu items #337

Merged
merged 1 commit into from
Jan 4, 2019
Merged

[Label] Adjust image height of image labels in menu items #337

merged 1 commit into from
Jan 4, 2019

Conversation

lubber-de
Copy link
Member

@lubber-de lubber-de commented Dec 31, 2018 •
edited
Loading

Description

Images in image label had wrong height when they were used within a menu item.

Testcase

http://jsfiddle.net/n75faL4y/8/

Screenshot

Before

image

After

image

Closes

Semantic-Org/Semantic-UI#5247

@lubber-de lubber-de added type/bug Any issue which is a bug or PR which fixes a bug lang/css Anything involving CSS state/awaiting-reviews Pull requests which are waiting for reviews tag/sui-issue Taken from an existing Issue/PR of SUI labels Dec 31, 2018
@lubber-de lubber-de added this to the 2.7.x milestone Dec 31, 2018
ColinFrick
ColinFrick approved these changes Dec 31, 2018
View reviewed changes
Copy link
Member

@ColinFrick ColinFrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

y0hami
y0hami approved these changes Jan 4, 2019
View reviewed changes
Copy link
Member

@y0hami y0hami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@y0hami y0hami merged commit 7ac1cb3 into fomantic:develop Jan 4, 2019
@y0hami y0hami removed state/awaiting-reviews Pull requests which are waiting for reviews labels Jan 4, 2019
@lubber-de lubber-de deleted the fix/5247/menu_item_image_label branch January 4, 2019 14:38
@lubber-de lubber-de modified the milestones: 2.7.x, 2.7.2 Jan 4, 2019
@y0hami y0hami mentioned this pull request Feb 4, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@y0hami y0hami y0hami approved these changes

@ColinFrick ColinFrick ColinFrick approved these changes

@prudho prudho Awaiting requested review from prudho

Assignees
No one assigned
Labels
lang/css Anything involving CSS tag/sui-issue Taken from an existing Issue/PR of SUI type/bug Any issue which is a bug or PR which fixes a bug
Projects
None yet
Milestone
2.7.2
Development

Successfully merging this pull request may close these issues.
3 participants
@lubber-de @ColinFrick @y0hami