Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Menu] Keep auto width for icon menu sizes #345

Merged

Conversation

lubber-de
Copy link
Member

Description

icon menu should always have its width getting auto calculated by the size of their icons and/or labels. This is basically already the case unless somebody adds any size like mini to the icon menu. The menu would get a fixed width then which does not really look right.

Testcase

http://jsfiddle.net/joe2ks5w/2/
Remove the CSS Part to see current behavior

Screenshot

image

Closes

Semantic-Org/Semantic-UI#5607

@lubber-de lubber-de added type/bug Any issue which is a bug or PR which fixes a bug lang/css Anything involving CSS tag/sui-issue Taken from an existing Issue/PR of SUI labels Jan 1, 2019
@lubber-de lubber-de added this to the 2.7.x milestone Jan 1, 2019
Copy link
Member

@y0hami y0hami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@ColinFrick ColinFrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@y0hami y0hami merged commit 7a204d4 into fomantic:develop Jan 2, 2019
@lubber-de lubber-de modified the milestones: 2.7.x, 2.7.2 Jan 2, 2019
@lubber-de lubber-de deleted the fix/5607/auto_width_sized_icon_menus branch January 2, 2019 18:34
@y0hami y0hami mentioned this pull request Feb 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang/css Anything involving CSS tag/sui-issue Taken from an existing Issue/PR of SUI type/bug Any issue which is a bug or PR which fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants