Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Formvalidation] Radio buttons do not validate if the first is disabled #372

Merged
merged 1 commit into from
Jan 11, 2019
Merged

[Formvalidation] Radio buttons do not validate if the first is disabled #372

merged 1 commit into from
Jan 11, 2019

Conversation

lubber-de
Copy link
Member

@lubber-de lubber-de commented Jan 8, 2019 •
edited
Loading

Description

  • If the first option of a radio group was disabled the whole validation of that group was skipped
  • Additional fix: is empty always returned false for empty radio button groups
  • I also removed unnecessary sets of fieldValid=true..because it is initially true in all cases anyway

Testcase

Follow the short info in the fiddles (TL;DR: press both buttons 😄 )

Broken

https://jsfiddle.net/u2abzw3r/1/

Fixed

https://jsfiddle.net/u2abzw3r/2/

Closes

Semantic-Org/Semantic-UI#6511

@lubber-de
fix(formvalidation): Only skip disabled radio/checkbox if _every_ opt…
6e8373a 
…ion is disabled, support radios in "is empty", removed unnecessary variable setting
@lubber-de lubber-de added type/bug Any issue which is a bug or PR which fixes a bug lang/javascript Anything involving JavaScript state/awaiting-reviews Pull requests which are waiting for reviews tag/sui-issue Taken from an existing Issue/PR of SUI labels Jan 8, 2019
@lubber-de lubber-de added this to the 2.7.x milestone Jan 8, 2019
@lubber-de lubber-de mentioned this pull request Jan 8, 2019
Open
@lubber-de
Copy link
Member Author

lubber-de commented Jan 9, 2019 •
edited
Loading

The testcase fiddle urls were wrong...sorry for this, i changed them to the correct URLs in the description now.

ColinFrick
ColinFrick approved these changes Jan 11, 2019
View reviewed changes
Copy link
Member

@ColinFrick ColinFrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

y0hami
y0hami approved these changes Jan 11, 2019
View reviewed changes
Copy link
Member

@y0hami y0hami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@y0hami y0hami merged commit b5a4d54 into fomantic:develop Jan 11, 2019
@lubber-de lubber-de modified the milestones: 2.7.x, 2.7.2 Jan 11, 2019
@lubber-de lubber-de removed the state/awaiting-reviews Pull requests which are waiting for reviews label Jan 11, 2019
@lubber-de lubber-de deleted the fix/6511/radio_first_disabled_validates branch February 5, 2019 11:33
@lubber-de lubber-de mentioned this pull request Feb 27, 2020
Merged
This was referenced Aug 1, 2020
Open
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@y0hami y0hami y0hami approved these changes

@ColinFrick ColinFrick ColinFrick approved these changes

@prudho prudho Awaiting requested review from prudho

Assignees
No one assigned
Labels
lang/javascript Anything involving JavaScript tag/sui-issue Taken from an existing Issue/PR of SUI type/bug Any issue which is a bug or PR which fixes a bug
Projects
None yet
Milestone
2.7.2
Development

Successfully merging this pull request may close these issues.
3 participants
@lubber-de @ColinFrick @y0hami