[Step] make steps wrap by default as intended for single step #397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lubber-de
added
type/bug
y0hami
requested changes
Jan 15, 2019
There was a problem hiding this comment.
This shouldn't be applied when a step as .unstackable https://fomantic-ui.com/elements/step.html#unstackable
|
@hammy2899 Done. New fiddle http://jsfiddle.net/v8yrgs6t/ |
lubber-de
changed the title
y0hami
added
type/feat
y0hami
removed
state/awaiting-reviews
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A huge amount of steps were overflowing the viewport if the amount of steps was not explicit given as classname. It was already intended to wrap (a single step already got
flex-wrap:wrap), but it was missing for grouping by usingsteps.This is ignored when
unstackable stepsis used because a possible overflow is wanted behavior.If a step amount is given to the group (
six steps), the behavior stays as before: Each step will reduce itself to stay inline. (Also part of the testcase below)Testcase
http://jsfiddle.net/v8yrgs6t/
Remove the CSS to see the issue
Screenshot
Before
After
Closes
Semantic-Org/Semantic-UI#4880
Semantic-Org/Semantic-UI#4867
Semantic-Org/Semantic-UI-React#1114