Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Progress] Don't show min-width progress bar when module was not initialized #425

Merged
merged 1 commit into from
Jan 25, 2019

Conversation

lubber-de
Copy link
Member

Description

Progressbars which have not been initialized by javascript or don't have the data-percent attribute set (which will be set on initialization) still showed the min-width progressbar background.

Testcase

https://jsfiddle.net/ba51wkjm/

Closes

#424

…initialized (therefore wont have any data-percent info)
@lubber-de lubber-de added lang/css Anything involving CSS state/awaiting-reviews Pull requests which are waiting for reviews 🐛 bugfix labels Jan 25, 2019
@lubber-de lubber-de added this to the 2.7.2 milestone Jan 25, 2019
Copy link
Member

@y0hami y0hami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@prudho prudho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@y0hami y0hami merged commit f17fa6c into fomantic:develop Jan 25, 2019
@lubber-de lubber-de deleted the fix/424/fresh_progress_no_bar branch January 25, 2019 14:33
@lubber-de lubber-de removed the state/awaiting-reviews Pull requests which are waiting for reviews label Jan 25, 2019
@y0hami y0hami mentioned this pull request Feb 4, 2019
@exoego exoego added type/bug Any issue which is a bug or PR which fixes a bug and removed 🐛 bugfix labels May 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang/css Anything involving CSS type/bug Any issue which is a bug or PR which fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants