[Segment] Fix support for inverted, secondary or tertiary in horizontal segments #470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…segments in horizontal group
lubber-de
added
type/bug
lubber-de
removed
the
state/awaiting-reviews
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
inverted,secondaryortertiarysegment was not working inside ofhorizontal segmentsgroupTestcase
Because the reason for this is an unnecessary background-color property (obviously copy/pasted when it was introduced in 2015 by Semantic-Org/Semantic-UI@6258196 ) , it cannot be simply removed in a fiddle by another css class, so you have to manually remove the property in chrome developer tools to see the fix (See screenshot below for better explanation proof) I could not find any reason why the segment itself inside a horizontal segment group should have an explicit transparent background set. It only makes sense for the segment group.
http://jsfiddle.net/hoqmxbka/
Screenshot
Closes
Semantic-Org/Semantic-UI#3587
Semantic-Org/Semantic-UI-React#3310