Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Input] Tiny size variant was missing #492

Merged
merged 1 commit into from
Feb 20, 2019
Merged

[Input] Tiny size variant was missing #492

merged 1 commit into from
Feb 20, 2019

Conversation

lubber-de
Copy link
Member

@lubber-de lubber-de commented Feb 15, 2019 •
edited
Loading

Description

The input element was missing the tiny size variant, thus such inputs were diplayed in medium / default size.

Testcase

Remove CSS to see issue
https://jsfiddle.net/xeungdv8/1/

Before After
image image

Closes

Semantic-Org/Semantic-UI-React#3439

@lubber-de lubber-de added type/bug Any issue which is a bug or PR which fixes a bug lang/css Anything involving CSS state/awaiting-reviews Pull requests which are waiting for reviews tag/sui-issue Taken from an existing Issue/PR of SUI labels Feb 15, 2019
@lubber-de lubber-de added this to the 2.7.x milestone Feb 15, 2019
y0hami
y0hami approved these changes Feb 15, 2019
View reviewed changes
Copy link
Member

@y0hami y0hami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lubber-de lubber-de mentioned this pull request Feb 19, 2019
Closed
ColinFrick
ColinFrick approved these changes Feb 20, 2019
View reviewed changes
Copy link
Member

@ColinFrick ColinFrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@y0hami y0hami merged commit dc4bf77 into fomantic:develop Feb 20, 2019
@y0hami y0hami removed state/awaiting-reviews Pull requests which are waiting for reviews labels Feb 20, 2019
@lubber-de lubber-de deleted the fix/3439/tiny_input_size_missing branch February 20, 2019 13:25
@lubber-de lubber-de modified the milestones: 2.7.x, 2.7.3 Feb 20, 2019
@y0hami y0hami mentioned this pull request Apr 1, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@y0hami y0hami y0hami approved these changes

@ColinFrick ColinFrick ColinFrick approved these changes

@prudho prudho Awaiting requested review from prudho

Assignees
No one assigned
Labels
lang/css Anything involving CSS tag/sui-issue Taken from an existing Issue/PR of SUI type/bug Any issue which is a bug or PR which fixes a bug
Projects
None yet
Milestone
2.7.3
Development

Successfully merging this pull request may close these issues.
3 participants
@lubber-de @ColinFrick @y0hami