Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Button] Basic button loop always used "primary" for margin #537

Merged

Conversation

lubber-de
Copy link
Member

@lubber-de lubber-de commented Mar 5, 2019

Description

Thanks to @dylmye for the hint

The consequences loop for basic buttons always used "primary" when setting the margin instead of the supplied consequences name .

Closes

Semantic-Org/Semantic-UI#6766

@lubber-de lubber-de added type/bug Any issue which is a bug or PR which fixes a bug lang/css Anything involving CSS state/awaiting-reviews Pull requests which are waiting for reviews tag/sui-issue Taken from an existing Issue/PR of SUI labels Mar 5, 2019
@lubber-de lubber-de added this to the 2.7.3 milestone Mar 5, 2019
Copy link
Member

@y0hami y0hami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@prudho prudho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@y0hami y0hami merged commit c44b09b into fomantic:develop Mar 7, 2019
@lubber-de lubber-de deleted the fix/6766/basic_button_margin_duplicate branch March 7, 2019 16:09
@lubber-de lubber-de removed the state/awaiting-reviews Pull requests which are waiting for reviews label Mar 7, 2019
@y0hami y0hami mentioned this pull request Apr 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang/css Anything involving CSS tag/sui-issue Taken from an existing Issue/PR of SUI type/bug Any issue which is a bug or PR which fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants