Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Slider] Don't conflict with checkbox #553

Merged
merged 1 commit into from
Mar 12, 2019
Merged

[Slider] Don't conflict with checkbox #553

merged 1 commit into from
Mar 12, 2019

Conversation

lubber-de
Copy link
Member

Description

The slider component conflicts with the existing slider checkbox especially in terms of padding

Screenshots

Single example Table example
slider_checkbox_bad slider_checkbox_bad2

Closes

#547

@lubber-de lubber-de added type/bug Any issue which is a bug or PR which fixes a bug lang/css Anything involving CSS state/awaiting-reviews Pull requests which are waiting for reviews labels Mar 9, 2019
@lubber-de lubber-de added this to the 2.7.x milestone Mar 9, 2019
@lubber-de lubber-de mentioned this pull request Mar 9, 2019
Closed
y0hami
y0hami approved these changes Mar 9, 2019
View reviewed changes
Copy link
Member

@y0hami y0hami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

prudho
prudho approved these changes Mar 11, 2019
View reviewed changes
Copy link
Contributor

@prudho prudho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ColinFrick
ColinFrick approved these changes Mar 11, 2019
View reviewed changes
Copy link
Member

@ColinFrick ColinFrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lubber-de lubber-de modified the milestones: 2.7.x, 2.7.3 Mar 11, 2019
@y0hami y0hami merged commit 9c3ee37 into fomantic:develop Mar 12, 2019
@y0hami y0hami removed state/awaiting-reviews Pull requests which are waiting for reviews labels Mar 12, 2019
@y0hami y0hami mentioned this pull request Apr 1, 2019
Merged
@lubber-de lubber-de deleted the fix/547/slider_checkbox_conflict branch April 2, 2019 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@y0hami y0hami y0hami approved these changes

@prudho prudho prudho approved these changes

@ColinFrick ColinFrick ColinFrick approved these changes

Assignees
No one assigned
Labels
lang/css Anything involving CSS type/bug Any issue which is a bug or PR which fixes a bug
Projects
None yet
Milestone
2.7.3
Development

Successfully merging this pull request may close these issues.
4 participants
@lubber-de @ColinFrick @prudho @y0hami