Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Chore] Update jquery dependency for bower to the same version as for npm #585

Merged
merged 1 commit into from
Mar 26, 2019

Conversation

lubber-de
Copy link
Member

Description

Increasing the jquery dependency for bower installations to the same version as for the usual npm package (^3.2.1) "fixes" an issue with animations used for example in accordion in case one is still using jquery 1.8
More info in the related SUI issue

Closes

Semantic-Org/Semantic-UI#5731

@lubber-de lubber-de added type/build Anything related to the build process state/awaiting-reviews Pull requests which are waiting for reviews tag/sui-issue Taken from an existing Issue/PR of SUI labels Mar 24, 2019
@lubber-de lubber-de added this to the 2.7.4 milestone Mar 24, 2019
Copy link
Member

@y0hami y0hami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@prudho prudho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@y0hami y0hami removed the state/awaiting-reviews Pull requests which are waiting for reviews label Mar 26, 2019
@y0hami y0hami merged commit 5958171 into fomantic:develop Mar 26, 2019
@y0hami y0hami modified the milestones: 2.7.4, 2.7.3 Mar 26, 2019
@lubber-de lubber-de deleted the fix/5731/bower_jquery_update branch March 26, 2019 13:36
@y0hami y0hami mentioned this pull request Apr 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tag/sui-issue Taken from an existing Issue/PR of SUI type/build Anything related to the build process
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants