-
-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Dropdown] Height variation #587
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a semantic note here: hasn't taller
more sense that higher
?
Higher/ highest or taller/tallest... I am fine with both 😀 what does our native speaker @hammy2899 say? |
IMHO I think adding words for height will have just as much of a problem as the size modifiers. In FUI we have I think we need to think more about the terminology we use before we add anything to the framework so we can prevent breaking changes in the future. |
And what about |
@prudho That's a good point and that would also be reusing current terminology. ref: https://fomantic-ui.com/elements/placeholder.html#line-length |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@exoego could you please replace higher
and highest
classes by long
and very long
to reuse our current terminology. Thanks !
Changed to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
We should also add |
I don't think shorter dropdown make sense in terms of end-user readability (showing less items). If you think consitency is more important, what factors should be for
(unit: items) |
🤔 How should it behave then? So which max-height setting should be set when using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I think the table @exoego shows is perfect, I would agree that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Adds examples of height variation proposed in fomantic/Fomantic-UI#587
Description
This PR adds height variation to dropdown module so that more items can be glanced at once.
This is helpful if dropdown have tons of items (e.g. Countries, States/Providences, Divisions, something like that).
This is usable if every items can be shown at once within the height of window without scroll bar.
If there are so many items that requires scroll bar, user can consider columnar variation proposed in #586.
Screenshot (when possible)
Closes
Closes #545