Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some fixes #7

Merged
merged 4 commits into from
Jun 8, 2018
Merged

Some fixes #7

merged 4 commits into from
Jun 8, 2018

Conversation

@prudho prudho changed the title Typo Some fixes Jun 5, 2018
@y0hami y0hami changed the base branch from master to next June 5, 2018 16:57
@y0hami y0hami added the state/awaiting-reviews Pull requests which are waiting for reviews label Jun 5, 2018
@y0hami y0hami self-requested a review June 5, 2018 16:57
Copy link
Member

@y0hami y0hami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both are valid and work

@y0hami y0hami removed the state/awaiting-reviews Pull requests which are waiting for reviews label Jun 5, 2018
@y0hami y0hami added this to the 2.4.x milestone Jun 5, 2018
@prudho
Copy link
Contributor Author

prudho commented Jun 7, 2018

I think I'll use this PR for little fixes, that will allow me to not create many branches just for little patches...

@y0hami y0hami added state/awaiting-reviews Pull requests which are waiting for reviews Can Merge and removed Can Merge state/awaiting-reviews Pull requests which are waiting for reviews labels Jun 7, 2018
@y0hami y0hami merged commit 651ad1d into fomantic:next Jun 8, 2018
@lubber-de lubber-de modified the milestones: 2.4.x, 2.4.4 Sep 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants