feat(*): add dynamic LESS compilation of component variations #781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lubber-de
added
type/feat
|
Added support for adjustable sizes, so we only have to define all desired sizes in a list @variationButtonSizes: mini, tiny, small, large, big, huge, massive;This would also allow someone to add even more/custom desired size definition names at a central place as long as the appropriate font-size variables will be also declared in a custom theme's site.variables: @thin: 0.1em;
@fat: 2em;
@ultra: 10em;
@unbelievable: 15em;
@variationButtonSizes: mini, small, thin, fat, ultra, unbelievable; |
…variationButtonSize:false'
|
This is something I thought about too, and I think it's dooable. It will provide a great customization level and will allow a better final framework size. |
|
@lubber-de anything happening with this? |
|
Nobody, beside @prudho replied so far.. But that also means nobody complained about it 😊 |
# Conflicts: # src/definitions/elements/button.less
… indeterminate and fitted optional
…, ribbon, tag, basic, circular, image, attached and size optional
…r, loading, icon, labeled, action, fluid and size optional
…and size optional
…ed, fitted, dividing, block, attached, tags and size optional
…, aligned, floated, fluid, avatar, spaced, centered, groups and size optional
…mage, floated, link, aligned, fitted, animated, horizontal, suffixed, selection, divided, celled, relaxed and size optional
# Conflicts: # src/definitions/collections/table.less # src/definitions/elements/input.less # src/definitions/elements/list.less
|
@hammy2899 Merged develop and resolved the conflicts 🙂 |
# Conflicts: # src/definitions/collections/form.less # src/definitions/elements/input.less # src/definitions/modules/dropdown.less # src/definitions/modules/slider.less
ColinFrick
previously approved these changes
Nov 13, 2019
prudho
previously approved these changes
Nov 13, 2019
# Conflicts: # src/definitions/collections/table.less # src/definitions/elements/container.less # src/definitions/modules/toast.less # src/definitions/views/card.less
lubber-de
dismissed stale reviews from exoego, prudho, ColinFrick, and y0hami
via
954187e
ColinFrick
approved these changes
Nov 13, 2019
y0hami
changed the title
y0hami
removed
state/awaiting-reviews
|
Docs added by fomantic/Fomantic-UI-Docs#377 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is a proposal for a solution to allow users to define which variations of an element will be compiled .
It was often requested to have a possibility to remove certain variations of an element from of the compiled CSS File.
I invented a central file
variation.variableswhich is loaded into the default site.variables to enable all variations by default. If now somebody wants to remove for example thetertiaryvariant of thebuttonelement one just has to add@variationButtonTertiary: falseto their custom themessite.variablesSide effect improvements
divider,revealandcardalso have size options nowheaderandstatisticalso received missing size options (mini,big,massive)statisticsize options