Filter on exported symbols in 1.11

See JuliaLang/julia#50105 (comment) for context
fonsp · Oct 7, 2023 · 10cb888 · 10cb888
1 parent 3b37549
commit 10cb888
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/src/runner/PlutoRunner.jl b/src/runner/PlutoRunner.jl
@@ -324,9 +324,17 @@ function try_macroexpand(mod::Module, notebook_id::UUID, cell_id::UUID, expr; ca
     return (sanitize_expr(expr_to_save), expr_hash(expr_to_save))
 end
 
+function exported_names(mod::Module)
+    @static if VERSION ≥ v"1.11.0-DEV.469"
+        filter!(b -> isexported(mod, b), names(mod; all=true))
+    else
+        names(mod)
+    end
+end
+
 function get_module_names(workspace_module, module_ex::Expr)
     try
-        Core.eval(workspace_module, Expr(:call, :names, module_ex)) |> Set{Symbol}
+        Core.eval(workspace_module, Expr(:call, exported_names, module_ex)) |> Set{Symbol}
     catch
         Set{Symbol}()
     end

diff --git a/test/ExpressionExplorer.jl b/test/ExpressionExplorer.jl
@@ -805,7 +805,6 @@ end
         (" 🍕🍕", (6, 10), (3, 5)), # a 🍕 is two UTF16 codeunits
     ]
     for (s, (start_byte, end_byte), (from, to)) in tests
-        @show s
         @test PlutoRunner.map_byte_range_to_utf16_codepoints(s, start_byte, end_byte) == (from, to)
     end
 end