Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompatHelper: bump compat for FuzzyCompletions to 0.5, (keep existing compat) #1866

Conversation

github-actions[bot]
Copy link
Contributor

This pull request changes the compat entry for the FuzzyCompletions package from 0.3,0.4 to 0.3,0.4, 0.5.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

@fonsp
Copy link
Owner

fonsp commented Feb 1, 2022

@aviatesk Were there any breaking changes?

@aviatesk
Copy link
Contributor

aviatesk commented Feb 1, 2022

I made a change corresponding to JuliaLang/julia#43865.
It's breaking since now MethodCompletion object's input_types field is rename to tt and it doesn't have orig_method/func fields.
But as far as Pluto doesn't make use of those fields, you can safely update FuzzyCompletions.jl to v0.5.0

@fonsp fonsp marked this pull request as draft February 2, 2022 11:29
@fonsp
Copy link
Owner

fonsp commented Feb 2, 2022

TODO: update NotebookLaunchProject.toml

@fonsp
Copy link
Owner

fonsp commented Feb 12, 2022

Fixed on main

@fonsp fonsp closed this Feb 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants