Device change event: properties are not updated. Fixes #9 (thanks @sh…

…atsky)
fontanon · Aug 9, 2014 · 44d2605 · 44d2605
1 parent 320cd33
commit 44d2605
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/udev-discover.in b/udev-discover.in
@@ -334,8 +334,7 @@ class UDevDiscoverGUI(GConfStore):
 
         self.logger.info(_('Device removed: %s') % device.nice_label)
 
-    def changed_device(self, device_finder, device):
-        old_device = self.device_finder.get_devices_tree()[device.path]
+    def changed_device(self, device_finder, device, old_device):
 
         if self.rows.has_key(device.path):
             # Remove from tree first

diff --git a/udevdiscover/devicefinder.py b/udevdiscover/devicefinder.py
@@ -48,8 +48,8 @@ class DeviceFinder(GObject.GObject):
             (GObject.TYPE_PYOBJECT,)),
         'removed': (GObject.SignalFlags.RUN_LAST, None, 
             (GObject.TYPE_PYOBJECT,)),
-        'changed': (GObject.SignalFlags.RUN_LAST, None, 
-            (GObject.TYPE_PYOBJECT,)),
+        'changed': (GObject.SignalFlags.RUN_LAST, None,
+            (GObject.TYPE_PYOBJECT, GObject.TYPE_PYOBJECT,)),
     }
 
     def __init__(self, subsystems='', parent_tree=False):
@@ -143,7 +143,9 @@ def device_changed(self, gudevice, subsystem):
         '''Called when a device has been updated'''
 
         dev = device.get_device_object(gudevice)
-        self.emit('changed', dev)
+        old_dev = self.devices_tree[dev.path]
+        self.devices_tree[dev.path] = dev
+        self.emit('changed', dev, old_dev)
 
 GObject.type_register(DeviceFinder)