Skip to content

Commit

Permalink
[smallcaps_before_ligatures] should not have is_ttf condition
Browse files Browse the repository at this point in the history
This check works just fine on OTFs, no need for `conditions=["is_ttf"]`.

smallcaps_before_ligatures
On the Universal profile

(issue #4920)
  • Loading branch information
felipesanches committed Dec 21, 2024
1 parent 4da99f9 commit 3cf4fec
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@ A more detailed list of changes is available in the corresponding milestones for
- **[kerning_for_non_ligated_sequences]**: "Is there kerning info for non-ligated sequences?" (issue #2954 / https://github.com/simoncozens/fontspector/commit/eaa52447ddc4a42e26b6430841a43026870d8a48)

### Changes to existing checks
### On the Universal profile
- **[smallcaps_before_ligatures]:** This check works just fine on OTFs, no need for `conditions=["is_ttf"]` (issue #4920)

### On the Google Fonts profile
- **[googlefonts/axes_match]:** Skip if remote_style is static

Expand Down
1 change: 0 additions & 1 deletion Lib/fontbakery/checks/smallcaps_before_ligatures.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@
This check attempts to detect this kind of mistake.
""",
proposal="https://github.com/fonttools/fontbakery/issues/3020",
conditions=["is_ttf"],
)
def check_smallcaps_before_ligatures(ttFont):
"""
Expand Down

0 comments on commit 3cf4fec

Please sign in to comment.