Skip to content

Commit

Permalink
Previously experimental checks now made effective
Browse files Browse the repository at this point in the history
The dates indicate when each check was originally implemented as temporarily experimental.

Promoted on Universal profile:
  - 2024/Jul/17: ufo_consistent_curve_type
  - 2024/Aug/09: designspace_has_consistent_codepoints
  - 2024/Aug/09: designspace_has_consistent_glyphset
  - 2024/Aug/09: designspace_has_default_master
  - 2024/Aug/09: designspace_has_sources
  - 2024/Aug/09: ufo_features_default_languagesystem
  - 2024/Aug/09: ufolint
  - 2024/Aug/09: ufo_no_open_corners
  - 2024/Aug/09: ufo_recommended_fields
  - 2024/Aug/09: ufo_required_fields
  - 2024/Aug/09: ufo_unnecessary_fields
  - 2024/Aug/12: designspace_has_consistent_groups
  • Loading branch information
felipesanches committed Dec 3, 2024
1 parent b1acd10 commit f9c0bdc
Show file tree
Hide file tree
Showing 2 changed files with 23 additions and 13 deletions.
24 changes: 23 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,11 +1,33 @@
Below are the noteworthy changes from each release.
A more detailed list of changes is available in the corresponding milestones for each release in the Github issue tracker (https://github.com/googlefonts/fontbakery/milestones?state=closed).

## Upcoming release: 0.13.0a6 (2024-Nov-??)
## Upcoming release: 0.13.0 (2024-Dec-??)
- ...


## 0.13.0a6 (2024-Dec-03)
### Noteworthy code-changes
- **Users are encouraged to try this pre-release as we're approaching the date when we'll cut a final v0.13.0 release...**
- Full fix for bug where check details with more severe status would be missing from the HTML report if a check with the same ID but less severe status was omitted (issue #4687)


### Previously experimental checks now made effective
The dates indicate when each check was originally implemented as temporarily experimental.

#### Promoted on Universal profile
- 2024/Jul/17: **ufo_consistent_curve_type**
- 2024/Aug/09: **designspace_has_consistent_codepoints**
- 2024/Aug/09: **designspace_has_consistent_glyphset**
- 2024/Aug/09: **designspace_has_default_master**
- 2024/Aug/09: **designspace_has_sources**
- 2024/Aug/09: **ufo_features_default_languagesystem**
- 2024/Aug/09: **ufolint**
- 2024/Aug/09: **ufo_no_open_corners**
- 2024/Aug/09: **ufo_recommended_fields**
- 2024/Aug/09: **ufo_required_fields**
- 2024/Aug/09: **ufo_unnecessary_fields**
- 2024/Aug/12: **designspace_has_consistent_groups**

### New checks
#### On the OpenType profile
- **[opentype/fvar/axis_ranges_correct]:** Replaces **opentype/varfont/ital_range**, **opentype/varfont/slnt_range**, **opentype/varfont/wdth_valid_range** and **opentype/varfont/wght_valid_range**
Expand Down
12 changes: 0 additions & 12 deletions Lib/fontbakery/checks/ufo.py
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,6 @@ def designspace_sources(designspace):
problems early in the process.
""",
proposal="https://github.com/fonttools/fontbakery/pull/1736",
experimental="Since 2024/Aug/09",
)
def check_ufolint(ufo):
"""Run ufolint on UFO source directory."""
Expand Down Expand Up @@ -107,7 +106,6 @@ def check_ufolint(ufo):
unitsPerEm, ascender, descender, xHeight, capHeight and familyName.
""",
proposal="https://github.com/fonttools/fontbakery/pull/1736",
experimental="Since 2024/Aug/09",
)
def check_ufo_required_fields(ufo_font):
"""Check that required fields are present in the UFO fontinfo."""
Expand Down Expand Up @@ -139,7 +137,6 @@ def check_ufo_required_fields(ufo_font):
This includes fields that should be in any production font.
""",
proposal="https://github.com/fonttools/fontbakery/pull/1736",
experimental="Since 2024/Aug/09",
)
def check_ufo_recommended_fields(ufo_font):
"""Check that recommended fields are present in the UFO fontinfo."""
Expand Down Expand Up @@ -179,7 +176,6 @@ def check_ufo_recommended_fields(ufo_font):
year is deprecated since UFO v2.
""",
proposal="https://github.com/fonttools/fontbakery/pull/1736",
experimental="Since 2024/Aug/09",
)
def check_ufo_unnecessary_fields(ufo_font):
"""Check that no unnecessary fields are present in the UFO fontinfo."""
Expand Down Expand Up @@ -219,7 +215,6 @@ def check_ufo_unnecessary_fields(ufo_font):
can be properly parsed and does include valid source file references.
""",
proposal="https://github.com/fonttools/fontbakery/pull/3168",
experimental="Since 2024/Aug/09",
)
def check_designspace_has_sources(designspace_sources):
"""See if we can actually load the source files."""
Expand All @@ -235,7 +230,6 @@ def check_designspace_has_sources(designspace_sources):
We expect that designspace files declare on of the masters as default.
""",
proposal="https://github.com/fonttools/fontbakery/pull/3168",
experimental="Since 2024/Aug/09",
)
def check_designspace_has_default_master(designSpace):
"""Ensure a default master is defined."""
Expand All @@ -253,7 +247,6 @@ def check_designspace_has_default_master(designSpace):
""",
conditions=["designspace_sources"],
proposal="https://github.com/fonttools/fontbakery/pull/3168",
experimental="Since 2024/Aug/09",
)
def check_designspace_has_consistent_glyphset(designSpace, config):
"""Check consistency of glyphset in a designspace file."""
Expand Down Expand Up @@ -287,7 +280,6 @@ def check_designspace_has_consistent_glyphset(designSpace, config):
""",
conditions=["designspace_sources"],
proposal="https://github.com/fonttools/fontbakery/pull/3168",
experimental="Since 2024/Aug/09",
)
def check_designspace_has_consistent_codepoints(designSpace, config):
"""Check codepoints consistency in a designspace file."""
Expand Down Expand Up @@ -337,7 +329,6 @@ def check_designspace_has_consistent_codepoints(designSpace, config):
http://adobe-type-tools.github.io/afdko/OpenTypeFeatureFileSpecification.html#4b-language-system
""",
proposal="https://github.com/googlefonts/fontbakery/issues/4011",
experimental="Since 2024/Aug/09",
)
def check_ufo_features_default_languagesystem(ufo_font):
"""Check that languagesystem DFLT dflt is present in the features.fea file."""
Expand Down Expand Up @@ -371,7 +362,6 @@ def check_ufo_features_default_languagesystem(ufo_font):
""",
conditions=["ufo_font"],
proposal="https://github.com/fonttools/fontbakery/pull/4795",
experimental="Since 2024/Jul/17",
)
def check_ufo_consistent_curve_type(config, ufo: Ufo):
"""Check that all glyphs across the source use the same curve type"""
Expand Down Expand Up @@ -428,7 +418,6 @@ def check_ufo_consistent_curve_type(config, ufo: Ufo):
""",
conditions=["ufo_font"],
proposal="https://github.com/fonttools/fontbakery/pull/4808",
experimental="Since 2024/Aug/09",
)
def check_ufo_no_open_corners(config, ufo):
"""Check the sources have no corners"""
Expand Down Expand Up @@ -468,7 +457,6 @@ def check_ufo_no_open_corners(config, ufo):
whole Designspace, so this check helps flag if this isn't the case.
""",
proposal="https://github.com/fonttools/fontbakery/pull/4814",
experimental="Since 2024/Aug/12",
)
def check_designspace_has_consistent_groups(config, designSpace):
"""Confirms that all sources have the same kerning groups per Designspace."""
Expand Down

0 comments on commit f9c0bdc

Please sign in to comment.