Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Builds fail intermitently with "FileNotFoundError" (Montserrat-Black.ttf) #4041

Closed
felipesanches opened this issue Feb 2, 2023 · 6 comments · Fixed by #4127
Closed

Builds fail intermitently with "FileNotFoundError" (Montserrat-Black.ttf) #4041

felipesanches opened this issue Feb 2, 2023 · 6 comments · Fixed by #4127
Assignees
Milestone

Comments

@felipesanches
Copy link
Collaborator

https://github.com/googlefonts/fontbakery/actions/runs/4075537481/jobs/7022061236

Screenshot from 2023-02-02 15-03-21

@felipesanches
Copy link
Collaborator Author

A-ha! You know which issue is this one? It's the 4041!

@miguelsousa
Copy link
Contributor

More than one test must be leveraging the same file and they're stepping on each other.

@felipesanches
Copy link
Collaborator Author

Do these tests run in parallel within any given operating system and python version?

@miguelsousa
Copy link
Contributor

The tests are executed independently of each other. They ran in parallel, but there's never more than 8 tests running at any given time (because of this pytest setting).

The fact that the tests are called independently doesn't guarantee that they run in total isolation; if one test happens to be hardcoded to delete file A from location B (for whatever reason) and another test is also hardcoded to do the same, if they happen to run at the same time the likelihood of one of them failing is going to be high. Of course, this isn't a problem if the tests are run sequentially.

@felipesanches
Copy link
Collaborator Author

I think I found the solution!

Screenshot from 2023-03-07 16-03-55
Screenshot from 2023-03-07 16-03-33

@felipesanches felipesanches self-assigned this Mar 7, 2023
@felipesanches felipesanches added this to the 0.8.12 milestone Mar 7, 2023
@miguelsousa
Copy link
Contributor

@felipesanches any progress on the fix. This problem is blocking PRs again. See #4122

@miguelsousa miguelsousa changed the title Builds fail intermitently with "FileNotFoundError" Builds fail intermitently with "FileNotFoundError" (Montserrat-Black.ttf) Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants