Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Purge known-wrong endings from glyph names to check #4469

Merged
merged 2 commits into from
Feb 1, 2024
Merged

Purge known-wrong endings from glyph names to check #4469

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f340a51
Purge known-wrong endings from glyph names to check
yanone Feb 1, 2024
af5e517
update CHANGELOG.md
felipesanches Feb 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,11 @@ A more detailed list of changes is available in the corresponding milestones for
- Added templating for the HTML reporter. We were mixing a lot of HTML and code in the same reporter, leading to messy code that's hard to improve. But now we use Jinja2 to feed the JSON output from the serialize reporter into a bunch of HTML templates. The reporter code is a lot simpler, and as a bonus, we make it easier for profile owners to change the look-and-feel of their reports. (PR #4460)

### New checks
#### On the Universal Profile
#### Added to the Universal Profile
- **EXPERIMENTAL - [com.google.fonts/check/varfont/family_axis_ranges]:** Check that family axis ranges are indentical. (issue #4445)
- **EXPERIMENTAL - [com.google.fonts/check/tabular_kerning]:** Check that tabular numerals and symbols have no kerning. (issue #4440)

#### On the Google Fonts Profile
#### Added to the Google Fonts Profile
- **EXPERIMENTAL - [com.google.fonts/check/metadata/has_tags]:** Check that the font family appears in the tags spreadsheet. (issue #4465)

### Migration of checks
Expand All @@ -26,6 +26,7 @@ A more detailed list of changes is available in the corresponding milestones for
- **[com.google.fonts/check/arabic_spacing_symbols]:** Also check U+FBC2 ARABIC SYMBOL WASLA ABOVE (issue #4417)
- **[com.google.fonts/check/contour_count]:** Use `ttFont.getBestCmap()` to avoid potential ERROR. (issue #3601)
- **[com.google.fonts/check/valid_glyphnames]:** Fix an outdated URL (issue #4080)
- **[com.google.fonts/check/alt_caron]:** Expanded to catch casing variants like "caroncomb.case" as well. The check previously didn't catch L+caroncomb.case, because the it relies on Unicodes to identify wrong accents. Now, we're purging known-wrong endings (e.g. .case) before resolving the Unicode, so that caroncomb.case can be found. (issue #3308 / PR #4469)

#### On the OpenType Profile
- **[com.google.fonts/check/varfont/bold_wght_coord]:** Only check for a bold instance on fonts where the weight range extends to 700. (issue #4373)
Expand Down
8 changes: 7 additions & 1 deletion Lib/fontbakery/profiles/universal.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2562,7 +2562,13 @@ def com_google_fonts_check_alt_caron(ttFont):
if len(glyph.components) > 1:
for component in glyph.components:
# Uses absolutely wrong caron mark
codepoints = reverseCmap.get(component.glyphName, set())
# Purge other endings in the future (not .alt)
codepoints = reverseCmap.get(
component.glyphName.replace(".case", "")
.replace(".uc", "")
.replace(".sc", ""),
set(),
)
if codepoints.intersection(WRONG_CARON_MARKS):
passed = False
yield FAIL, Message(
Expand Down
Loading