tests: catch ClipperException when calling Execute before any AddPath #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calling `Execute` on an empty `Pyclipper` instance would silently pass without exception in previous pyclipper 1.0.7 with Clipper lib version 6.2.1. Now, the `Clipper::Execute` method returns unsuccessful if called before any `AddPath` or `AddPaths`, so pyclipper duly raises an exception.
anthrotype
added a commit
to googlefonts/fontmake
that referenced
this pull request
Jan 8, 2018
or else with pyclipper 1.1.0 we get a pyclipper.ClipperException: See fonttools/pyclipper#14
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling
Executeon an emptyPyclipperinstance would silently pass without exception in previous pyclipper 1.0.7 with Clipper lib version 6.2.1.Now, the
Clipper::Executemethod returns unsuccessful if called before anyAddPathor
AddPaths, so pyclipper duly raises an exception.Client code may need to be adjusted accordingly.