Unlazify data and images on comparison
#165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madig
changed the title
data and imagesdata and images on comparison
madig
force-pushed
the
unlazify-data-images
branch
from
50ab401 to
5d11c42
Compare
madig
added a commit
to simoncozens/iondrive
that referenced
this pull request
Sep 10, 2021
anthrotype
approved these changes
Sep 17, 2021
- It's only relevant for the read() constructor, not for standalone instantiation, so no init. - Standalone instantiation cannot have lazy data by definition, so default to False.
anthrotype
approved these changes
Sep 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, both attributes are only unlazified when you do
font1 == font2, but not when comparing the individual attributes likefont1.data == font2.data.