Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add bounds/controlPointBounds properties #82

Merged
merged 2 commits into from
Jun 3, 2020
Merged

Add bounds/controlPointBounds properties #82

merged 2 commits into from
Jun 3, 2020

Conversation

khaledhosny
Copy link
Collaborator

For compatibility with defcon.

anthrotype
anthrotype reviewed Jun 1, 2020
View reviewed changes
Copy link
Member

@anthrotype anthrotype left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Could you add a test as well?

src/ufoLib2/objects/contour.py Outdated Show resolved Hide resolved
@khaledhosny
Add bounds/controlPointBounds properties
8b29cf4 
For compatibility with defcon.
@khaledhosny
Remove slightly misleading sentence
d4c3e49 
Control bounds by definition are not ink bounds.
@khaledhosny
Copy link
Collaborator Author

Thanks! Could you add a test as well?

I added a font test, which I guess calls the other code. I couldn’t figure out how to add more tests.

anthrotype
anthrotype approved these changes Jun 3, 2020
View reviewed changes
Copy link
Member

@anthrotype anthrotype left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@anthrotype anthrotype merged commit e9a5c5d into master Jun 3, 2020
@anthrotype anthrotype deleted the bounds branch June 3, 2020 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@madig madig madig left review comments

@anthrotype anthrotype anthrotype approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@khaledhosny @madig @anthrotype