Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multishared cascading config #127

Closed
3 tasks
wvengen opened this issue Jun 27, 2014 · 2 comments
Closed
3 tasks

multishared cascading config #127

wvengen opened this issue Jun 27, 2014 · 2 comments

Comments

@wvengen
Copy link
Member

wvengen commented Jun 27, 2014

Now that a configuration screen is present in wvengen/feature-config_db, the multishared plugin needs to be able to work with it; meaning that sub-foodcoops (like with fc-eindhoven) need to take the configuration of the master foodcoop (central).

  • sub-foodcoops take over config from master foodcoop
  • sub-foodcoops can specify their own overrides
  • figure out how to handle differences between master and sub foodcoops; are there any?
@wvengen
Copy link
Member Author

wvengen commented Jul 1, 2014

I've tried to add an inherit configuration key for inheriting config from a different foodcoop. This involves running select_foodcoop, reading the keys, then going back to select_foodcoop for the current foodcoop. This is a bit of overhead for each fetching of a configuration key.

Solution: in the multishared plugin, hook getting a configuration value to

  1. Find it in current foodcoop's database
  2. Find it in current foodcoop's config
  3. Find it in joined foodcoop's database
  4. Find it in joined foodcoop's config

This requires removing something like <<: *parent_coop in the config for foodcoops using join_scope. It should be possible to do these things without needing to call select_foodcoop, just querying the database and config hash.

@wvengen
Copy link
Member Author

wvengen commented Jul 10, 2015

We won't be continuing in this direction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant