Allow foodcoops to configure their settings #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wvengen
changed the title
|
Fix or workaround needed for foodcoop-adam#127. Perhaps the easiest, for now, is to disable editable configuration when the multishared plugin is enabled. |
wvengen
force-pushed
the
feature-config_db
branch
from
588fa4c
to
55f5486
Compare
and use proper config defaults so that configuration editing has sensible default values
Conflicts: app/helpers/admin/configs_helper.rb
wvengen
force-pushed
the
feature-config_db
branch
from
55f5486
to
8b935c3
Compare
Conflicts: app/helpers/admin/configs_helper.rb
wvengen
force-pushed
the
feature-config_db
branch
from
54615f5
to
10a193a
Compare
wvengen
added a commit
that referenced
this pull request
Sep 2, 2014
Allow foodcoops to configure their settings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finally, a solution for #24.
One reason for using
RailsSettings::CachedSettingsis that it caches by default, which is very suitable for these settings. Since the caching strategy is on-disk by default, this works between processes too. Another reason is that we are using key-value pairs already.There are some helpers for easily creating form elements, which may evolve into a DSL at some point, but for now I'm happy to have this.