Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release 4.7.1 #777

Closed
20 of 24 tasks
JuliusR opened this issue Oct 14, 2020 · 16 comments
Closed
20 of 24 tasks

release 4.7.1 #777

JuliusR opened this issue Oct 14, 2020 · 16 comments
Milestone

Comments

@JuliusR
Copy link
Contributor

JuliusR commented Oct 14, 2020

Can we schedule a bugfix release 4.7.1? There are at least two foodcoops that are waiting for #773 .

  • Plan
    • Create milestone
    • Select bugs to target
    • Pick freeze date, after which no big changes occur until release
    • Pick release date (and update milestone)
    • Start writing release notes
  • Communicate to mailing-list foodsoft-dev@
  • Merge, test, check, double check
  • At release date
    • Merge any new translations in the source tree (run script/crowdin-pull, commit changes but not new files)
    • Make sure tests are ok (GitHub actions)
    • Finalise release notes and update CHANGELOG.md
    • Bump VERSION (use X.Y.Z version number)
    • Commit with message "Bumped new version: X.Y.Z"
    • Tag vX.Y.Z
    • Update tag latest-release (for download links)
    • Bump VERSION file to vX.Y.99, commit with message "continue development after release" to master.
    • Check tags latest-release, X.Y.Z and X.Y are building on Docker
  • Announce
  • Celebrate!
@JuliusR JuliusR added this to the 4.7.1 milestone Oct 14, 2020
@JuliusR
Copy link
Contributor Author

JuliusR commented Oct 17, 2020

Some days have passed since 4.7.0, and not many bugs have been reported. I would like to deploy the fix for #772 soon because the bug disables an important feature of the foodsoft (considering my foodcoop).

From my point of view, there can be a 4.7.1 release based on the current master (4fa5c4e4043433). Would you like to omit some of those fixes, or are there any additional bugsfixes you would like to include in an upcoming 4.7.1?

I suggest a freeze and release date around next weekend, i.e., October 24th.

I have never created a release before, but I think I can make it based on the instructions. Translations can be skipped, I guess. Anyone willing to help?

What do you think about my suggestions? I will wait for your feedback before proceeding.

@wvengen @paroga

@paroga
Copy link
Member

paroga commented Oct 17, 2020

IMHO we can just use the master branch. I've created #778 for a found regression, which we should include in 4.7.1. Unfortunately I had no time to create a test for it and therefore didn't pushed it to master.

@wvengen
Copy link
Member

wvengen commented Oct 20, 2020

I'll be happy to do a new release.
Not sure about going to master instead of releases. I like the idea that users can use features sooner and more immediate feedback on features. But when an issue occurs, then we must fix it, releases are tested more. Personally I would not be ready for that.

@JuliusR
Copy link
Contributor Author

JuliusR commented Oct 25, 2020

Not sure about going to master instead of releases.

This is not what I had in mind. I was talking about including all of the recent changes from master for 4.7.1 (rather than cherry-picking individual bug fixes).

@JuliusR
Copy link
Contributor Author

JuliusR commented Oct 25, 2020

I suggest a freeze and release date around next weekend, i.e., October 24th.

Sorry, I missed that date because I was too busy. My new suggestion is: Let us get #778 done, and release 4.7.1 as soon as possible.

@JuliusR
Copy link
Contributor Author

JuliusR commented Nov 2, 2020

My foodcoop is craving for 4043433. However, I do not know how to handle #778, which is blocking this release. I am seeing three options:

  1. We test and merge Fix setting the ArticlePrice only for one order after 3a6276a. #778 soon. I can help if you explain me what to do, but I can not do this on my own.
  2. We postpone Fix setting the ArticlePrice only for one order after 3a6276a. #778 for 4.7.2, and release 4.7.1 based on the current master now.
  3. We wait some more time before we release 4.7.1 including Fix setting the ArticlePrice only for one order after 3a6276a. #778, but we deploy deploy foodcoops.net based on the current master once.

My preference is option 2. What do you think, @wvengen and @paroga?

@JuliusR
Copy link
Contributor Author

JuliusR commented Dec 29, 2020

I am proceeding with option 2.

@wvengen
Copy link
Member

wvengen commented Dec 29, 2020

Super, thank you!
Sorry for the delay in answering.

@JuliusR
Copy link
Contributor Author

JuliusR commented Dec 29, 2020

I need help with the docker setup. My current status is #793, and docker hub shows new builds. However, I do not know how to manage the docker-hub tags.

  • Do I need additional (docker-hub) secrets?
  • Should we setup github actions for managing tagged docker images?

@wvengen
Copy link
Member

wvengen commented Dec 29, 2020

I think if you tag on Foodsoft, Docker hub does its thing automatically. Make sure to make the v4.7.1 tag, and to bump latest-release (force-push that one).

@JuliusR
Copy link
Contributor Author

JuliusR commented Dec 29, 2020

My plan was to test the full docker-compose setup on my machine before finalizing the release. In order to make it available, I created and pushed the tag 4.7.1-rc0. I can not find that tag on docker hub, though. Maybe docker hub does not like the -rc0 suffix in the tag name?

Let us first finish our discussion in #793. Then I will try to test the docker-compose setup with that outcome.

@JuliusR
Copy link
Contributor Author

JuliusR commented Dec 30, 2020

I have tested the migration from 4.7.0 to 4.7.1-rc locally. I was using the full docker-compose setup with one foodsoft instance (foodsoft_demo) in a multicoop environment.

@JuliusR
Copy link
Contributor Author

JuliusR commented Dec 30, 2020

I have created the tag v4.7.1, and I have updated the tag latest-release. The docker-image builds are in progress. Naming can be improved, but everything seems to work.

I suggest to publish the following announcement text:

Hello,

Foodsoft 4.7.1 has been released. Foodsoft is an online software for running a non-profit foodcoop (a collective do-it-yourself supermarket) with a product catalog, order cycle, accounting, and tasks.

This is a bugfix release. It fixes several minor issues, and it fixes the article search in the external database. See the changelog for details.

If you need help upgrading your instance, or other support, please contact the foodsoft-discuss mailing-list.

Best,
Julius

foodsoft-discuss | github | foodcoops.net | @foodsoft.dev

P.S. Please feel free to share this announcement to others who might be interested!

@wvengen
Copy link
Member

wvengen commented Dec 31, 2020

Thanks, @JuliusR 🎉
I invite you to send this message to the foodsoft-announce mailing-list, as you've made this happen.

@wvengen
Copy link
Member

wvengen commented Dec 31, 2020

I've lost access to the Twitter account, unfortunately. I need to see if I can dig up the credentials from some old place (hopefully - I lost access to the domain used for the emailaddress).

@JuliusR
Copy link
Contributor Author

JuliusR commented Dec 31, 2020

I've lost access to the Twitter account, unfortunately. I need to see if I can dig up the credentials from some old place (hopefully - I lost access to the domain used for the emailaddress).

Ah, I see. I will omit the twitter link in the accouncement then. Let us hope you can re-gain access.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants