fix searching in external article database (#772)

[JuliusR]

Can we use this simple fix for #772 ?

[wvengen]

Thanks for finding the issue here! 💯
Could this introduce a security issue?

[JuliusR]

Could this introduce a security issue?

This is the correct question. I believe the answer is "no" because we are using the result for the following two purposes only:

• highlighting the matched name parts in the view
• passing the query to ransack (where to_unsafe_h is called right away)

I perfectly agree that safety should be obvious, so my first attempt with to_unsafe_h is bad practice.

[JuliusR]

I updated the code to avoid to_unsafe_h. Could you have a look again please?

[wvengen]

Thank you, this cleans up the existing code too. Assuming you've tested this well, 👍

[paroga]

Please rebase your commits when pushing them to master to avoid the useless merge commits, which make the history a lot less readable. The change in the rewritten history is now 4043433.