Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/run send to supplier as job #1084

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

mortbauer
Copy link
Contributor

This pull request depends on #1083.

  • it will run the send_to_supplier mail in a job
  • re-raise any errors in the mail path so it can be re-run

The reason for it is that we had an unnoticed issue with our email setup, which also lead to mails to suppliers not sent from the foodsoft. This errors are not even visible in the email errors overview site since only email problems to members are shown there.

* the way it was before failed jobs wouldn't correcly anymore
* now it is a bit more explicit but jobs can be re-run
Copy link
Member

@wvengen wvengen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense! 👍 (looked at last two commits only here)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants