Better workaround for touch devices #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tock/foodsoft#34, closes foodcoops#104)" This reverts commit add4afd. Conflicts: app/assets/javascripts/application.js
|
The code looks fine. Did you Would be quite a lot of effort to test for me. |
|
Yep, thanks for checking. |
wvengen
added a commit
that referenced
this pull request
Feb 3, 2014
Better workaround for touch devices
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous fix for #104 breaks select2 in some cases. This seems to be a better workaround (tested on stock Android and Fennec; behaviour should be equal with desktop browsers).