Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make 'settle directly' less dangerous #276

Merged
merged 1 commit into from
Apr 2, 2014

Conversation

wvengen
Copy link
Member

@wvengen wvengen commented Mar 21, 2014

see #275

  • add comment to order when using 'settle directly'

@jwollbold
Copy link

Thank you for your very fast reaction! The clear message when settling directly (which I first understood even in Dutch :-) solves the main problem. Will someone change the message in the German version? I would translate it as:
"Vorsicht, du rechnest gerade eine Bestellung ab, ohne die Gruppenkonten zu belasten! Dies sollte nur geschehen, wenn die Bestellung schon manuell abgerechnet wurde, oder wenn du wirklich weißt was du tust."

In the medium term, is it also possibly to mark respective orders in the overview? This would clarify the consequences further and facilitate retrospective financial control much. Or is this already implemented?

Regards Johannes

@wvengen
Copy link
Member Author

wvengen commented Mar 21, 2014

Thanks for your quick response, Johannes. I think adding a mark that settling was skipped is a helpful idea! It could easily be added as an order comment.

@wvengen
Copy link
Member Author

wvengen commented Mar 21, 2014

And thanks for the German translation, I'll either put it in, or update localeapp when this is merged.

@wvengen
Copy link
Member Author

wvengen commented Mar 27, 2014

Ok, added comment when settling directly. Will merge this for the next version.

wvengen added a commit that referenced this pull request Apr 2, 2014
@wvengen wvengen merged commit a0a82e2 into foodcoops:master Apr 2, 2014
@wvengen wvengen deleted the feature-move_settle_directly branch April 2, 2014 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants