Add expected delivery date #355
Conversation
|
Ah! Would you care to explain a bit behind the need for this? I like addition of relevant dates, but I'm not sure yet where these could be placed best. (In the foodcoop-adam fork there's a similar "pickup date" field, more as a sign to people at/from which date they can pickup their goods. This is also shown on the fax pdf as a "deliver before" date.) |
|
sounds like the pickup date is the same. the additional page is for people who check the delivery: the people rotate in our food coop and with the simple list of orders it was not clear, which PDF they should print out (some of our orders hang in the closed state for over a month since we get only a invoice for them once per month) |
|
It seems we're on the same page. For the foodcoop-adam fork, I experimented with a current_orders plugin, which lists all finished_but_not_closed orders, and also allows to modify articles and ordergroups for those orders. I've described it a bit in #358. Is that a direction that would be suitable for you? |
|
imho your solution is too complex for us. we need only a list, which list the "group PDF" and "fax PDF" grouped by the pickup date. having additional option might confuse people who do not know the whole system in detail |
|
So you only need to download the PDFs, right? And you don't use the receive functionality? |
|
yes, exactly |
|
I'm wondering how Foodsoft can be suitable for your situation, as well as ours. Something to think about. For your current case: would a download button (menu) in the order overview screen also work? There you already have a list of the currently relevant orders. |
|
there are too many closed orders. we get a delivery every week, but only an invoice per month. we had problems in the last weeks that people did not find all relevant orders. |
|
maybe we can only add the pickup date to the database and the usual order pages for now? and think about the other points in a next step? |
|
Ah! I've been thinking of introducing something like a "pickup day" context. Each order then belongs to a specific pickup day, so that Foodsoft knows which orders belong together. Some screens could then group by pickup day. Like the ordering, order management and finance screen. Perhaps we need a pickup-day/distribution "role", so that members in this group can view a screen like you suggested in this pull request. And these could also do the other stuff in #358, if so desired. |
|
Agree to add pickup date now, and leave the rest for later. Thanks for keeping the scope managable :) |
wvengen
force-pushed
the
master
branch
2 times, most recently
from
8100b26
to
d6bf09b
Compare
paroga
force-pushed
the
expeted_delivery_date
branch
5 times, most recently
from
c9e76d8
to
d388e24
Compare
| description1_period: | ||
| starts: "open from %{starts}" | ||
| starts_ends: "open from %{starts} until %{ends}" | ||
| pickup: " and can be picked up on %{pickup}" |
There was a problem hiding this comment.
let's put the leading space in the code - can be hard for translators to see at all
paroga
force-pushed
the
expeted_delivery_date
branch
from
d388e24
to
28e2a37
Compare
|
ping |
|
Cool, I'll have a look. |
| @@ -4,6 +4,7 @@ | |||
| = f.input :starts, as: :date_picker_time | |||
| = f.input :boxfill, as: :date_picker_time if @order.is_boxfill_useful? | |||
| = f.input :ends, as: :date_picker_time | |||
| = f.input :pickup, as: :date_picker | |||
There was a problem hiding this comment.
class input-small would be nice here to be in-line with the other date inputs
|
Looking good. (Too bad |
This additional date helps users to find the correct order if the time between end and pickup varies a lot.
paroga
force-pushed
the
expeted_delivery_date
branch
from
28e2a37
to
f286dd6
Compare
|
Thanks! :) |
No description provided.