Dockerfile for production

[paroga]

No description provided.

[dan-nl]

suggest creating 2 files for the moment; e.g. Dockerfile.prod and Dockerfile.dev and build the appropriate file. entrypoint file is a great idea.

[wvengen]

It would be nice to generate a REVISION file (which is used here) when building a docker image. But this is a nice to have that can be added later.

[paroga]

I'd like to keep the main Dockerfile for production. We can add a Dockerfile.dev if we really want that later too.

Improving the .dockerignoresounds like a good idea, but is not mandatory to get it working again. There are additional changes too, which should be done to the Dockerfile to reduce the resulting size (unistall the dev-packages after bundler run).

I'll added generating the REVISION file.

[wvengen]

Wait a minute, does removing this mean that Foodsoft now runs as root? (Hope this is not a newbie Docker question.)

[paroga]

It's very uncommon to create a special user just for running the main entry point. Since it's a Docker container there are no "real root" rights in the container anyway and having an additional user does not offer a lot of additional security to the underlying system.

[wvengen]

Makes sense. Thanks for explaining!

[wvengen]

Thanks! And looking good. Besides the run-as-question, ready to merge, I'd say.
I think we can still remove mailcatcher from docker-compose.yml for production.

Did you manage to re-setup the docker hub build?

[paroga]

Updating the docker-compose.yml file is a completely different task, since it's for development only. I personally prefere to get rid of it anyway and provide an example in the Wiki pages instead to show an example Docker setup for production. I also like to remove the doc folder and put that information in the wiki too. What do you think?

[wvengen]

Great 👍

I know @dan-nl is working on a separate development and production docker setup, let's rework the rest with that.
Regarding the doc folder, I think it would be a good idea to have instructions on how to get it running in the source tree, so that it's there with the source code. Also, instructions may change over versions, keeping that in VCS allows one to have the right version (e.g. dependencies).

[wvengen]

One thing I didn't see yet: how about asset precompilation?